Adam Wolk said: > missing RDEP on devel/desktop-file-utils > missing @exec of update-desktop-database > missing @unexec-delete of update-desktop-database
Looks like you've tried initial version. Newer one was attached later
in the same thread.
> translation file(s) found without devel/gettext dependency in MODULES or
> RUN_DEPENDS
I don't think gettext should be a dependency here, python should handle
that.
> Python module without compiled version, consider using ${MODPY_BIN}
> ${MODPY_LIBDIR}/compileall.py: share/PySolFC/themes/clearlooks/create_imgs.py
> games/pysol
I've got rid of it, and of couple other files. Looks like they aren't
needed during runtime.
> Additionally I think that in pkg/PLIST:
>
> bin/pysol
>
> should be changed to
>
> @bin bin/pysol
pkg_create(1):
| @bin filename
| Describe the file as an OpenBSD binary executable (not a script).
So "@bin" does not seem to be needed here.
> installs icon pysol01.png in share/icons, it should go in
> share/pysol01/icons/ or like instead
> installs icon pysol02.png in share/icons, it should go in
> share/pysol02/icons/ or like instead
[...]
> 2. The .desktop icon seems wrong
I've moved them to share/pixmaps, which seems to make portcheck happy.
I tried to fix .desktop file accordingly, although I have no means of
seeing whether it was actually fixed.
Please, see another iteration over the port attached. FWIW it is kept
at openbsd-wip.
--
Dmitrij D. Czarkoff
pysol.tgz
Description: application/tar-gz
