On Wed, 27 May 2015 17:36:44 +0200
Francisco de Borja Lopez Rio <[email protected]> wrote:

> On Wed, May 27, 2015 at 05:09:09PM +0200, Adam Wolk wrote:
> > On Wed, 27 May 2015 16:11:13 +0200
> > Marc Espie <[email protected]> wrote:
> >
> > > py-oauth2-1.5.211(),py-paste-script-1.7.5()
> > >         /usr/local/lib/python2.7/site-packages/tests/__init__.py
> > >   /usr/local/lib/python2.7/site-packages/tests/__init__.pyc
> > >
> > >
> > > Those files have surprisingly generic names. I wonder if they
> > > should get packaged at all ?
> > >
> > > To ponder for python people.
> >
> > There is even one more strange thing. I just tried on amd64 snapshot
> > from May 20th. The make test step seems to fail at least for
> > www/py-paste-script.
> >
> > That's on a clean box that never had this package installed before.
> >
> > # make test
> > ===>  Regression tests for py-paste-script-1.7.5
> > cd /usr/ports/pobj/py-paste-script-1.7.5/PasteScript-1.7.5
> > && /usr/local/bin/py.test . /bin/sh: /usr/local/bin/py.test: not
> > found *** Error 127 in . (Makefile:38 'do-test')
> > *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2779
> > '/usr/ports/pobj/py-paste-script-1.7.5/.test_done') *** Error 1
> > in /usr/ports/www/py-paste-script
> > (/usr/ports/infrastructure/mk/bsd.port.mk:2476 'test')
> >
> 
> It seems that package should depend on py.test (a test runner) for
> running its tests. We have py.test 2.6.1 is in ports, maybe these
> ports Makefile should be updated?
> 
> Regards.
> 
> --
> 
> "Do nothing which is of no use." - Miyamoto Musashi
> ---------------------------------------------------------------------
> Francisco de Borja Lopez Rio ([email protected])
> Soluciones Informaticas Codigo23 S.L.U.
> http://www.codigo23.net


Just took a look at the makefile itself:
# NOTE: regression tests won't pass, because they need ZPTKit (which
# has shitloads of dependencies) and FakePlugin.  There isn't much
# point in porting them.
TEST_DEPENDS=   ${RUN_DEPENDS} \
                        devel/py-py

do-test:
        cd ${WRKSRC} && ${LOCALBASE}/bin/py.test .


Don't know why the test step is kept instead of NO_TESTS=Yes considering
the comment.

Anyway added devel/py-test to TEST_DEPENDS to make sure that the comment holds.
It does.


# make test
===>  Regression tests for py-paste-script-1.7.5
cd /usr/ports/pobj/py-paste-script-1.7.5/PasteScript-1.7.5 && 
/usr/local/bin/py.test .
============================= test session starts ==============================
platform openbsd5 -- Python 2.7.9 -- py-1.4.23 -- pytest-2.6.1
collected 0 items / 1 errors

==================================== ERRORS ====================================
______________________________ ERROR collecting . ______________________________

I'll spare you the large backtrace.

Regards,
Adam

Reply via email to