On 2015/05/27 12:37, Peter Schmiedeskamp wrote:
> I think this port is ready for commit, unless anyone has additional 
> corrections!

| # $OpenBSD: Makefile.template,v 1.72 2015/04/08 17:53:19 sthen Exp $
| 
| COMMENT =             convert OSM data to PgRouting format
| DISTNAME =            osm2pgrouting-2.0.0
| CATEGORIES =          geo
| 
| HOMEPAGE =            http://pgrouting.org
| 
| # GPLv2 only
| PERMIT_PACKAGE_CDROM =        Yes

As per Makefile.template and the majority of other ports,
WANTLIB usually goes here in the Makefile i.e. PERMIT_*, then
a blank line, then WANTLIB.

| # Dependencies
| #

No need for this ^^ comment

| MODULES =             devel/cmake
| BUILD_DEPENDS =               devel/boost databases/postgresql
| RUN_DEPENDS =         geo/pgrouting
| WANTLIB +=            c expat m pq stdc++

Looks like postgresql should be a LIB_DEPENDS not a BUILD_DEPENDS.
Common standard is to list dependencies one-per-line with \ for
continuation.

| 
| .include <bsd.port.mk>

Reply via email to