On Tue, Jun 02, 2015 at 03:12:40PM +0200, Pierre-Emmanuel André wrote:
> Hi,
> 
> Here is a diff to update imapsync to it's latest release.
> Please note that you need the new port p5-Data-Uniqid.
> Tested on @amd64.
> 
> Comments/OK ?

Why not drop EXTRACT_SUFX and let GH_* handle the tar.gz?
You may also want to use GH_TAGNAME.  Moreover HOMEPAGE can be dropped
with GH_ACCOUNT due to recent changes in bsd.port.mk.  I would also zap
the empty line after GH_PROJECT.

Regards,
Joerg

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/mail/imapsync/Makefile,v
> retrieving revision 1.13
> diff -u -p -u -p -r1.13 Makefile
> --- Makefile  11 Oct 2013 23:49:56 -0000      1.13
> +++ Makefile  2 Jun 2015 13:10:59 -0000
> @@ -1,24 +1,40 @@
>  # $OpenBSD: Makefile,v 1.13 2013/10/11 23:49:56 naddy Exp $
>  
> +GH_ACCOUNT =    imapsync
> +GH_PROJECT =    imapsync
> +
> +
>  COMMENT=     IMAP synchronization tool
>  
> -DISTNAME=    imapsync-1.350
> +DISTNAME=    imapsync-1.637
>  CATEGORIES=  mail
>  
>  MAINTAINER=  Pierre-Emmanuel Andre <p...@openbsd.org>
>  
> -# WTFPL
> +# NO_LIMIT
>  PERMIT_PACKAGE_CDROM=        Yes
>  
> -MASTER_SITES=        http://www.linux-france.org/prj/imapsync/dist/
> +HOMEPAGE=    https://github.com/imapsync/imapsync
>  
> -EXTRACT_SUFX=        .tgz
> +EXTRACT_SUFX=        .zip
> +
> +WRKDIST=     ${WRKDIR}/imapsync-${DISTNAME}
>  
>  RUN_DEPENDS= converters/p5-DateManip \
>               security/p5-IO-Socket-SSL \
>               security/p5-Digest-HMAC \
>               mail/p5-Mail-IMAPClient \
> -             devel/p5-Term-ReadKey
> +             devel/p5-Term-ReadKey \
> +             net/p5-IO-Socket-INET6 \
> +             security/p5-IO-Socket-SSL \
> +             devel/p5-IO-Tee \
> +             converters/p5-Unicode-String \
> +             www/p5-URI \
> +             security/p5-Authen-NTLM \
> +             devel/p5-File-Copy-Recursive \
> +             devel/p5-Parse-RecDescent \
> +             devel/p5-Test-Pod \
> +             devel/p5-Data-Uniqid
>  
>  NO_BUILD=    Yes
>  NO_TEST=     Yes
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/mail/imapsync/distinfo,v
> retrieving revision 1.10
> diff -u -p -u -p -r1.10 distinfo
> --- distinfo  18 Jan 2015 03:14:22 -0000      1.10
> +++ distinfo  2 Jun 2015 13:10:59 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (imapsync-1.350.tgz) = Td7sLY/qEisT2o5Xtdy26WTJCe1VvpgeSMSeF1w1PO8=
> -SIZE (imapsync-1.350.tgz) = 803049
> +SHA256 (imapsync-1.637.zip) = s+sR8i642E6lBVSGrn6CTtdBXtv+1X1gjU3bKVvBUFE=
> +SIZE (imapsync-1.637.zip) = 1085471

Reply via email to