On 06/03/15 10:30, [email protected] wrote:
> 
> Hi ports@
> 
> this updates p5-PSGI from 1.03 to 1.102, its a documentation
> only module, so don't causes any conflicts
> 
> ok, commit?
> 
> thanks
> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/www/p5-PSGI/Makefile,v
> retrieving revision 1.2
> diff -u -p -r1.2 Makefile
> --- Makefile  11 Mar 2013 11:44:46 -0000      1.2
> +++ Makefile  26 May 2015 01:44:19 -0000
> @@ -3,7 +3,7 @@
>  COMMENT =            perl Web Server Gateway Interface Specification
>  
>  MODULES =            cpan
> -DISTNAME =           PSGI-1.03
> +DISTNAME =           PSGI-1.102
>  CATEGORIES =         www
>  MAINTAINER =         Abel Abraham Camarillo Ojeda <[email protected]>
>  CPAN_AUTHOR  =       MIYAGAWA
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/www/p5-PSGI/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo  11 Dec 2010 09:46:56 -0000      1.1.1.1
> +++ distinfo  26 May 2015 01:44:26 -0000
> @@ -1,5 +1,2 @@
> -MD5 (PSGI-1.03.tar.gz) = zk2Aemr4Oyt/myk5WphMdA==
> -RMD160 (PSGI-1.03.tar.gz) = x3I7mqxhr53Hyh7gAlo1tb/9Fos=
> -SHA1 (PSGI-1.03.tar.gz) = M/MqKWB4gULOa42ZrBfJG6xABJo=
> -SHA256 (PSGI-1.03.tar.gz) = Bj5rX5UpzSvWRnxtqgJRdotS53xCuSgzbK6D8qo+Myw=
> -SIZE (PSGI-1.03.tar.gz) = 29518
> +SHA256 (PSGI-1.102.tar.gz) = pWxEZ0CRfahpJcKfxmM7nfg5shz5j2onCGWY7ZDuH0c=
> +SIZE (PSGI-1.102.tar.gz) = 36710
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/www/p5-PSGI/pkg/PLIST,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 PLIST
> --- pkg/PLIST 11 Dec 2010 09:46:56 -0000      1.1.1.1
> +++ pkg/PLIST 26 May 2015 01:45:35 -0000
> @@ -2,6 +2,8 @@
>  ${P5SITE}/PSGI/
>  ${P5SITE}/PSGI.pm
>  ${P5SITE}/PSGI.pod
> +${P5SITE}/PSGI/Extensions.pod
>  ${P5SITE}/PSGI/FAQ.pod
>  @man man/man3p/PSGI.3p
> +@man man/man3p/PSGI::Extensions.3p
>  @man man/man3p/PSGI::FAQ.3p
> 
> 

This uses Module::Install, and should have a
CONFIGURE_STYLE += modinst
In the Makefile.

You can tell this from the Makefile.PL
use inc::Module::Install;
name 'PSGI';
all_from 'PSGI.pm';
auto_set_repository;
WriteAll;

Or the fact there is a inc/Module/Install.pm included with the source.

Setting modinst replaces the bundled and old 1.06 version of
Module::Install and will use the  current 1.08 version in ports I've
been using 1.14 and I am just about to update to 1.16, by coping into
the inc directory.

Should just be a simple case of adding the extra line to the Makefile
in this case, others might need additional extensions, some are
incorrect for other reasons like missing entries in the MANIFEST.

Avoids possible future issues with perl 5.22 or later, and gets over the
issue the upstream maintenance hasn't updated what's bundled in the
source. It's easier to fix p5-Module-Install if xxx ports fail to build,
than to fix xxx individual ports using a bundled Module::Install that
fail, and if the fix is to use modinst why not do it now.

No additional Module::Install extensions are required in this case.

I have updated this to use modinst, for the previous version 1.03

$ cvs -R -q diff -uNp
Index: Makefile
===================================================================
RCS file: /home/cvs/ports/www/p5-PSGI/Makefile,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile
--- Makefile    11 Mar 2013 11:44:46 -0000      1.2
+++ Makefile    3 Jun 2015 12:24:06 -0000
@@ -11,4 +11,6 @@ CPAN_AUTHOR   =       MIYAGAWA
 # Perl
 PERMIT_PACKAGE_CDROM = Yes

+CONFIGURE_STYLE +=     modinst
+
 .include <bsd.port.mk>


Reply via email to