Joerg Jung <[email protected]> writes:
> Hi,
>
> thanks for looking into this!
>
> On Mon, Jun 22, 2015 at 02:04:47PM +0200, Jérémie Courrèges-Anglas wrote:
>> Joerg Jung <[email protected]> writes:
>>
>> > please find attached a port for net/geomyidae.
>> >
>> > $ cat pkg/DESCR
>> > Geomyidae is a daemon for serving the Gopher protocol.
>> > It is based on gopherd for Plan 9.
>> >
>> > Comments? OKs?
>>
>> The Makefile could be more useful: show the actual commands used, and
>> make the build respect CFLAGS. I also think that you'd better install
>> the program and manpage in post-install instead of patching the
>> Makefile.
>
> I wonder why you consider post-install better? Anyway, fine for me.
Two lines to add to Makefile, vs a several-lines patch that you can't
feed upstream. :)
>> The rc.d script should be tweaked, pexp should be just "${daemon}.*"
>> since geomyidae mangles the arguments (thus what's stored in
>> /var/run/rc.d/geomyidae is no longer usable).
>
> Sure, makes sense.
>
> Since geomyidae does not support chroot(2), I thought about starting it
> adding chroot(8) to $daemon in rc script. Of course, this would require
> logging adjustments to /var/gopher/log or something. Does that make
> sense, or too much drift?
I'd rather have upstream implement those features in the daemon itself,
but I won't object.
>> Regarding the program: it supports either IPv6 or IPv4, not both (since
>> on OpenBSD net.inet6.ip6.v6only == 1 and you can't change that), and by
>> default binds to IPv6. The manpage says it binds to 127.0.0.1 by
>> default but this is not true. I think it makes more sense to bind to
>> IPv4, 0.0.0.0 by default.
>
> Yes, somehow I have overseen this.
>
>> Diff against your tarball, and updated tarball attached.
>
> Thanks, OK to import?
ok jca@
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
