On 2015/06/28 22:38, Johan Huldtgren wrote:
> >It should only be a missing test depends. Can you retry with the
> >attached port installed ? Itself doesnt past its tests, and i dont give
> >a fuck about python - so no idea which othr port should depend on it..
> >if it's py-test itself or py-jwt or the other way round..
>
> I was looking at this myself, and if I disconnected my network I realized
> py-test-runner (which looked identical to yours) actually itself had
> a dependency on py-setuptools-scm, and that had a dependency on
> py-setuptools-version. *sigh* So here we go.
>
> Attached diff for py-jwt with new BUILD_DEPEND on py-test-runner
>
> New ports:
> devel/py-test-runner
> devel/py-setuptools-scm
> devel/py-setuptools-version
>
> This all builds and packages for me without an internet connection
> so I'm hoping I've caught all the hidden dependencies. I also see
> a py-test-runner fail tests, but I've been unable to figure out
> what's not working, so I set NO_TEST for now.
>
> thanks,
>
> .jh
> Index: py-jwt/Makefile
> ===================================================================
> RCS file: /cvs/ports/www/py-jwt/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -u -p -r1.1.1.1 Makefile
> --- py-jwt/Makefile 26 Jun 2015 07:35:50 -0000 1.1.1.1
> +++ py-jwt/Makefile 29 Jun 2015 02:28:04 -0000
> @@ -6,6 +6,8 @@ MODPY_EGG_VERSION = 1.3.0
> DISTNAME = PyJWT-${MODPY_EGG_VERSION}
> PKGNAME = py-jwt-${MODPY_EGG_VERSION}
> CATEGORIES = www
> +REVISION = 0
> +
> MAINTAINER = Johan Huldtgren <[email protected]>
>
> HOMEPAGE = http://github.com/jpadilla/pyjwt
> @@ -17,6 +19,8 @@ MODPY_PI = Yes
>
> MODULES = lang/python
> MODPY_SETUPTOOLS = Yes
> +
> +BUILD_DEPENDS = devel/py-test-runner
>
> RUN_DEPENDS = security/py-cryptography
>
Please zap the trailing . in py-test-runner/Makefile's COMMENT and
I would really prefer something that stands by itself in the DESCR
files ("the blessed package to manage your versions by scm tags",
"Adds a command to dynamically get the version from the VCS of
choice" - at least I think they should mention that they're for
use with setuptools). Otherwise OK.
