2015-07-10 1:50 GMT+03:00 Dmitrij D. Czarkoff <[email protected]>: > I can't test the library because I don't have account in vkontakte (and > I am not a KDE user), but the port looks OK with several notes: > > > Vadim Zhukov said: >> libkvkontakte/Makefile > | # $OpenBSD$ > | > | COMMENT = KDE4 library implementing VK.com API > | VERSION = 4.12.0 > | DISTNAME = libkvkontakte-${VERSION} > | > | SHARED_LIBS = kvkontakte 0.0 > > Shouldn't this be bumped? Port graphics/digikam-kde4,-vkontakte already > provides lib/libkvkontakte.so.0.0, and it is likely that at least some > interface changes happened between 4.4 and 4.12...
ABI actually didn't change since initial import of libkvkontakte code to Digikam. >> libkvkontakte/pkg/PLIST > | @comment $OpenBSD$ > | @pkgpath graphics/digikam-kde4,-vkontakte > > As I gather it should @conflict with graphics/digikam-kde4,-vkontakte > until digikam is updated. I am not sure though. The @conflict marker isn't needed because those packages share same package name stem, so they'll conflict implicitly. Only the @pkgpath marker is needed for smooth updates. >> libkvkontakte/pkg/DESCR > | KDELibs4-based C++ library for asynchronous interaction with VK social > network > | via its web API. Good point about version. I blindly copied the text from "homepage". And there is no KDELibs in KDE5 land... Capitalization is right, though. ;) So I tweaked both COMMENT and DESCR. Updated port is attached. -- WBR, Vadim Zhukov
libkvkontakte_port.tar.gz
Description: GNU Zip compressed data
