On Sat, Aug 15, 2015 at 10:37:52AM +0200, Ingo Feinerer wrote: > On Sat, Aug 15, 2015 at 10:00:13AM +0200, Antoine Jacoutot wrote: > > > - Add "@comment no checksum" in pkg/PLIST for lib/R/etc/Makeconf and > > > lib/R/etc/ldpaths as they are modified by "R CMD javareconf" (which we > > > describe in pkg/README); otherwise pkg_delete fails/complains. > > > > Doesn't this mean they'll get overwritten at each pkg update? > > Yes. I think this is fine as these lib/R/etc/* files are generated by > configure and are not typical configuration files to be edited by the > user (at least this is my impression). Moreover I am not confident that > these files could be directly used whenever there is an R update (what I > would expect from normal configuration files). > > The only reason to bother is if someone wants Java support. They need to > ensure that they run R CMD javareconf when needed (which might mean > after each pkg update). > > Manual configuration should go IMHO into ~/.R/Makevars (as outlined in > pkg/README). > > > Wouldn't it make more sense to make them @sample instead? > > If my above argument makes sense, then no.
Oki. That much more clear now, thanks :-) The diff reads fine to me fwiw. -- Antoine
