On Sat, Sep 26, 2015 at 03:34:53PM +0200, Jona Joachim wrote:
> Hi,
> weboob has a runtime dependency for SSLv3. The attached diff replaces
> SSLv3 usage with SSLv23.
> 
> 2015-09-26 15:02:52,557:ERROR:weboob:1.0:ouiboube.py:450:load_backends
> Unable to load module "cic": 'module' object has no attribute
> 'PROTOCOL_SSLv3'
> 
> This is already fixed in the upstream git repo.

I dont see this in
https://github.com/laurentb/weboob/blob/master/weboob/deprecated/browser/browser.py#L783

> +-    _PROTOCOLS = [ssl.PROTOCOL_TLSv1, ssl.PROTOCOL_SSLv3]
> ++    _PROTOCOLS = [ssl.PROTOCOL_SSLv23]

Im not sure removing TLSv1 makes sense... dont we want to deprecate
SSLv2 and SSLv3 here ? What upstream commit are you reffering to ?

Landry

Reply via email to