Daniel Jakots <[email protected]> writes:

> On Sat, 3 Oct 2015 14:14:59 +0100, Stuart Henderson <[email protected]>
> wrote:
>
>> On 2015/10/03 09:41, Daniel Jakots wrote:
>> > Here's an update to the latest stable release. My really light
>> > testing discovered a use after free. Thanks Quentin Rameau for
>> > providing a patch for it (committed upstream now).
>
> Thanks for your input, updated diff.

Regarding Stuart's comments, that your diff addresses:
- joerc.zh_TW should indeed have been @sampled, it is a config file
- .po files didn't need to be @sampled at all
- the new syntax files should have been @sampled too

Your updated diff also switched the bugfix in patches/ from
a hand-rolled patch to the result of ''make update-patches'', which is
desirable.

Describing the changes you've done makes it easier for reviewers. ;)

I have just committed your diff.  Thanks!
-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to