Hi Jérémie, thanks for looking into this!
>> attached is a tarball for a new port for wxGlade, a wxwidgets interface
>> designer:
>>
>> wxGlade is a GUI designer written in Python with the popular GUI
>> toolkit wxPython, that helps you create wxWidgets/wxPython user
>> interfaces. At the moment it can generate Python, C++, Perl, Lisp and
>> XRC (wxWidgets' XML resources) code.
>
> Looks fine to me, tested a bit with python code.
>
> Some nits:
>
> - I'd probably import it in x11 instead of devel.
> ("devel/ is too crowded".)
Makes sense.
> - the wxglade script should probably use ${SUBST_CMD} + ${MODPY_BIN}
> (absolute path) instead of hardcoding python2.7. Actually this shell
> script contains lots of stuff that don't make sense in a system-wide
> install, looking for code to execute in nearby directories. Upstream,
> it should probably be handled by setuptools entry_points/gui_scripts.
>
> We could strip it down to:
> #!/bin/sh
> exec ${MODPY_BIN} -m wxglade.wxglade "$@"
You are absolutely right, I changed the script to the short version
above, however python2.7 dumps core on my machine when I run this - it
seems to be related with py-gtk2 in sys.path. I did not have time to
investigate, so for now I changed it to call wxglade.py in site-packages
directly, which is a bit ugly but works.
> - in DESCR:
>
> It is not (and will never be) a full featured IDE, but simply a
> "designer": the generated code does nothing apart from displaying the
> created widgets. If you are looking for a complete IDE, maybe Boa
> Constructor, PythonCard or Spe (which includes wxGlade itself, BTW...)
> is the right tool.
>
> I understand that this comes from upstream, but those projects look
> pretty dead and aren't included in the ports tree. What about killing
> the last sentence?
Fully agreed.
> The tarball attached installs the manpage in the right place, adjusts
> python shebangs and partially enables tests (some need X11).
I added TEST_IS_INTERACTIVE=X11 so all test run out of the box, is this
a recommended practice?
Attached is an updated tarball with the above changes on top of the one
you already made, the same is also on openbsd-wip.
Cheers,
Daniel
wxglade.tgz
Description: Binary data
