Hi, Patrik Lundin <[email protected]> writes:
> On Mon, Oct 12, 2015 at 11:34:46PM +0100, Stuart Henderson wrote: >> On 2015/10/05 22:22, Patrik Lundin wrote: >> > The 1.4.8.2 version of opendnssec was just released. This version >> > incorporates the above mentioned fixes. You will find the port attached. >> >> Looks good to me. I've reserved uid/gid 757 so PLIST can be updated. >> > > Great, thanks :). > >> >> Only one thing I'm unsure about, I'd welcome other comments on this >> though: the naming of the mariadb flavour. It is technically correct, >> but we're not using -mariadb as a flavour name anywhere else, so I'd >> be inclined to name it "mysql" for consistency with the rest of the >> tree. >> > > This sounds reasonable to me. Moving the ports tree from using "mysql" > to "mariadb" in flavor names seems like something that should be done in > a more controlled fashion than having some ports slowly start diverging. +1 > Attached is a port with the uid/gid number updated to 757 in PLIST, as > well as having the "mariadb" name reverted to "mysql" (except in the > README file where I still refer to the mariadb-server package). Here's an updated tarball that incorporates the following changes: - merge two WANTLIB lines - zap a redundant rc_reload=NO line - tighten pexp - use default rc_check()
opendnssec.tgz
Description: Binary data
diff -pruN opendnssec.orig/Makefile opendnssec/Makefile --- opendnssec.orig/Makefile Tue Oct 13 09:30:50 2015 +++ opendnssec/Makefile Tue Oct 13 12:42:05 2015 @@ -15,7 +15,7 @@ MAINTAINER= Patrik Lundin <[email protected]> # BSD PERMIT_PACKAGE_CDROM= Yes -WANTLIB += c crypto iconv ldns m pthread xml2 z +WANTLIB += c crypto iconv ldns lzma m pthread xml2 z MASTER_SITES= http://dist.opendnssec.org/source/ @@ -33,8 +33,6 @@ CONFIGURE_ARGS+= --disable-pedantic FLAVORS= sqlite3 mysql FLAVOR?= sqlite3 - -WANTLIB+= lzma .if ${FLAVOR:Msqlite3} WANTLIB+= sqlite3 diff -pruN opendnssec.orig/pkg/opendnssec.rc opendnssec/pkg/opendnssec.rc --- opendnssec.orig/pkg/opendnssec.rc Sun Apr 27 15:42:57 2014 +++ opendnssec/pkg/opendnssec.rc Tue Oct 13 13:47:41 2015 @@ -8,20 +8,14 @@ daemon="${TRUEPREFIX}/sbin/ods-control" rc_reload=NO -pexp="ods-" +pexp="${TRUEPREFIX}/sbin/ods-(enforcerd|signerd)" -rc_reload=NO - rc_start() { ${rcexec} "${daemon} start" } rc_stop() { ${daemon} stop -} - -rc_check() { - pkill -0 "^${pexp}" } rc_cmd $1 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
