On Tue, Oct 20, 2015, at 05:31 AM, Alexey Suslikov wrote: > Aaron Bieber <aaron <at> bolddaemon.com> writes: > > > Changes: > > - A number of diffs have been upstream'd, so they can be removed. > > - Stop using ninja. > > - Build against node's OpenSSL (this one hurts, but is unavoidable > > currently). > > Can you please briefly explain what's wrong with system openssl?
Sure, basically they pull in very large portions of OpenSSL from the most recent version they can (post-LibreSSL fork): https://github.com/nodejs/node/blob/master/src/node_crypto.cc#L526 This includes stuff like SSL_set_cert_cb, and a few others that aren't in LibreSSL. Some of the functions will likely be added to LibreSSL, but not with out much consideration. For reference, this stuff was added in OpenSSL 1.0.2. Here is a thread about it: https://github.com/nodejs/node/issues/428 - I bet if enough people express interest in LibreSSL they will add support ;D > > > SUBST_VARS+= CFLAGS > > SUBST_VARS+= PREFIX > > SUBST_VARS+= LOCALBASE > > SUBST_VARS+= DISTFILES > > +SUBST_VARS+= M > > I'd rename M to NODE_MACHINE_ARCH so PLIST will be self-explaining > and doesn't push someone to look back into Makefile. > Agreed, but I think NODE_MACHINE_ARCH is a bit too verbose, I will go with NODE_ARCH.
