Rafael Sadowski <[email protected]> writes: > Hey @ports,
Hi,
> after really long time in jasperla/openbsd-wip and intensive testing from an
> openbsd-wip-user, I'm happy to push a ready tinc port.
>
> I hope this nice stuff will find some Okays or feedback.
I have been reviewing this port already, sadly the machine I tested it
on has since vanished. Here are the tweaks I found, mostly from memory:
- kill useless trailing backslashes
- fix tincd.rc header
- use ${rcexec} to start tincd, so that people can eg. put tincd in
a specific login class (eg. to have more file descriptors available)
tincd can change its uid after startup, is there any reason not to
enable this in the default config, by providing a dedicated
_tincd:_tincd user?
Updated tarball attached, diff below.
Cheers,
diff -pruN tinc.orig/Makefile tinc/Makefile
--- tinc.orig/Makefile Fri Oct 9 00:40:38 2015
+++ tinc/Makefile Mon Nov 2 22:06:59 2015
@@ -15,9 +15,9 @@ WANTLIB += c crypto lzo2 z
MASTER_SITES = http://www.tinc-vpn.org/packages/
-MODULES = converters/libiconv \
+MODULES = converters/libiconv
-LIB_DEPENDS += archivers/lzo2 \
+LIB_DEPENDS += archivers/lzo2
USE_GMAKE = Yes
USE_LIBTOOL= gnu
@@ -28,7 +28,7 @@ CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
LDFLAGS="-L${LOCALBASE}/lib"
CONFIGURE_ARGS = --sysconfdir=/etc \
- --prefix=${LOCALBASE} \
+ --prefix=${LOCALBASE}
.include <bsd.port.mk>
diff -pruN tinc.orig/pkg/tincd.rc tinc/pkg/tincd.rc
--- tinc.orig/pkg/tincd.rc Fri Oct 9 00:40:38 2015
+++ tinc/pkg/tincd.rc Mon Nov 2 22:08:40 2015
@@ -1,13 +1,13 @@
-# $OpenBSD:
#!/bin/sh
+#
+# $OpenBSD$
daemon="${TRUEPREFIX}/sbin/tincd"
. /etc/rc.d/rc.subr
-
rc_start() {
- ${daemon}
+ ${rcexec} "${daemon}"
}
rc_reload() {
tinc.tgz
Description: Binary data
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
