On 2015/11/10 19:26, Jérémie Courrèges-Anglas wrote: > Stuart Henderson <st...@openbsd.org> writes: > > > On 2015/11/10 14:00, Jérémie Courrèges-Anglas wrote: > >> -- char const *m4 = (p = getenv ("M4")) ? p : M4; > >> -+ char const *m4 = (p = getenv ("M4")) ? p : "/usr/bin/m4"; > > > > Note to reviewers: upstream supports this themselves now, this diff > > doesn't lose the ability to point M4 at /usr/bin/m4 for testing. > > Yup. The comment I added in the port Makefile isn't very clear about > it. Maybe the following one would be more helpful? > > # m4 from base groks -g, not --gnu. To use m4 from base instead of > # GNU m4, set M4=/usr/bin/m4 in the environment. > CONFIGURE_ENV+= ac_cv_prog_gnu_m4_gnu="-g"
Ah now I understand why you've set CONFIGURE_ENV like this - yes that's better, or we could expand it further: # Set bison to use "m4 -g" instead of "m4 --gnu" to permit use with m4 # from the base OS by setting M4=/usr/bin/m4 in the environment. This is # for development purposes; bison currently uses GNU regular expressions # which are not compatible with base m4. Pulling in GNU m4 seems less bad than opaquely generating the parsers on another OS.