On 2015/11/17 15:49, Michael McConville wrote:
> Their public dev list is [email protected]. It's probably worth
> letting them know.
dev@ according to their list page. Some of their readers seem a bit
funny about mails without diffs though.
> > sent /etc/passwd
> >
> > will crash because 71 lines (on my machine) don't fit in a single
> > slide and the code that looks for a small enough font is buggy. It
> > uses an unsigned 'j' variable in a loop that says (getfontsize()
> > sent.c:321) :
> >
> > for (j = NUMFONTSCALES - 1; j >= 0; j--) {
> >
> > so this will happily lead to huge j values, later used as indexes in
> > an array...
> >
> > Even with that fixed, the same getfontsize() function won't be able to
> > handle the lack of an appropriate font and reference font[-1] with joy
> > and fireworks.
This is fixed in their devel tree. Though it no longer crashes in these
cases, it still doesn't work nicely if there's no appropriate font, it
seems this is by design - http://lists.suckless.org/dev/1511/27591.html
has advice about how you're supposed to use this (paragraph starting
"The font sizes are calculated...").
> > Later in the oss-sec thread someone noticed that 'sent empty' with
> > empty beeing a 0-length file will also produce a memory access
> > error. Indeed with malloc.conf -> J it happily dereferences a
> > 0xd0d0d0d0d0d0d0 pointer since there is not such input as line[0] if
> > the file is empty.
But not for this. Same for a file with blank lines.
Besides all of these minor issues, it's missing a very important feature!
--snip--
FLAVORS= openbsd
FLAVOR?=
.if ${FLAVOR:Mopenbsd}
RUN_DEPENDS+= fonts/msttcorefonts
post-patch:
perl -pi -e 's/"dejavu"/"comic sans", "dejavu"/' ${WRKSRC}/config.def.h
.endif
--snip--
