On 2015/12/02 20:55, Daniel Jakots wrote:
> On Tue, 1 Dec 2015 22:51:21 +0100, Landry Breuil
> <[email protected]> wrote:
>
> > On Tue, Dec 01, 2015 at 10:17:46PM +0100, Daniel Jakots wrote:
> > > Hi Eric,
> > >
> > > I tried to update devel/py-py. I didn't want to spend too much time
> > > on it because I thought you might already have worked on it.
> >
> > Dont remove the ${MODPY_COMMENT} lines from PLIST as they're used for
> > py3 FLAVOR.
>
> Ok, I'm still trying to figure out when to trust make update-plist and
> when to not to :)
For python ports that have a python3 flavour, use 'FLAVOR=python3 make
REVISION=999 plist', reinstate MODPY_COMMENTs on the ${MODPY_PYCACHE}/
*directory* entries in plist (not file entries within that directory),
and check for any other unintended changes. (Also make sure that both
the normal and python3 flavours can be installed at the same time,
i.e. no conflicting files).
For python 2-only python ports, just 'make REVISION=999 plist' and check.
(REVISION=999 is a hack to avoid getting FULLPKGNAME subst'ed in place
of portname-${MODPY_EGG_VERSION} - if it has a pkg-readme file it will
need special treatment but this avoids extra work with the majority
of python ports).
> > Also, your mailer mangles diffs, see below :
>
> Sorry, I'll try to be more careful
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/py-py/Makefile,v
> retrieving revision 1.26
> diff -u -p -r1.26 Makefile
> --- Makefile 29 Sep 2015 10:52:11 -0000 1.26
> +++ Makefile 2 Dec 2015 19:43:27 -0000
> @@ -2,14 +2,13 @@
>
> COMMENT= cross-python path, ini-parsing, io, code, log facilities
>
> -MODPY_EGG_VERSION = 1.4.23
> +MODPY_EGG_VERSION = 1.4.30
> DISTNAME= py-${MODPY_EGG_VERSION}
> PKGNAME= py-${DISTNAME}
> -REVISION = 1
>
> CATEGORIES= devel
>
> -HOMEPAGE= http://doc.pylib.org/en/latest/
> +HOMEPAGE= https://pylib.readthedocs.org/en/latest
>
> MAINTAINER= Eric Faurot <[email protected]>
>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/py-py/distinfo,v
> retrieving revision 1.6
> diff -u -p -r1.6 distinfo
> --- distinfo 15 Sep 2014 19:41:03 -0000 1.6
> +++ distinfo 2 Dec 2015 19:43:27 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (py-1.4.23.tar.gz) = uo8qOJTK8RIXmaKyOdZ4c6Vr0N+iThZz2SmQqK5zcMo=
> -SIZE (py-1.4.23.tar.gz) = 189520
> +SHA256 (py-1.4.30.tar.gz) = twPldoXtfCgLGlHElqSYTYPYne8qkwtenl2lpsoVFRQ=
> +SIZE (py-1.4.30.tar.gz) = 191796
>
That's ok with me.
