Alexandr Shadchin <alexandr.shadc...@gmail.com> writes:
> On Wed, Dec 23, 2015 at 09:21:43PM +0100, Jérémie Courrèges-Anglas wrote:
>> Daniel Jakots <vigdis+o...@chown.me> writes:
>>
>> > On Wed, 23 Dec 2015 23:49:11 +0500, Alexandr Shadchin
>> > <alexandr.shadc...@gmail.com> wrote:
>> >
>> >> Hi,
>> >>
>> >> This diff updates py-mock to the latest release.
>> >> Add python3 flavor.
>> >>
>> >> Comments ? OK ?
>> >>
>> >
>> > I was working on it too (as I need it for another port) and I have
>> > quite the same diff. A comment inline, otherwise that's good :)
>> >
>> >>
>> >> Index: Makefile
>> >> ===================================================================
>> >> RCS file: /cvs/ports/devel/py-mock/Makefile,v
>> >> retrieving revision 1.7
>> >> diff -u -p -r1.7 Makefile
>> >> --- Makefile 29 Sep 2015 10:51:54 -0000 1.7
>> >> +++ Makefile 23 Dec 2015 18:44:30 -0000
>> >> @@ -2,11 +2,10 @@
>> >
>> > [snip]
>> >
>> >> +NO_TEST = Yes
>> >
>> > Any reason for that? It looks like that test works.
>>
>> The test suite isn't called. Needs a test-dep on devel/py-unittest2 and
>> a custom do-test target, eg. cd ${WRKSRC} && unit2 discover. There are
>> 6 errors that were not present before.
>>
>
> Errors due to the old py-unittest2.
Ah. ok jca@ for py-mock then.
>> Also devel/flake8's tests fail with this update, but I'm not sure
>> whether my-mock is to blame.
>>
>
> Fix flake8 attached (also works fine with py-mock 1.0.1)
Your patch is better than mine. ok jca@ fwiw, cc'ing maintainer.
Thanks,
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
