On Tue, Mar 8, 2016 at 12:29 PM, Nigel Taylor
<njtaylor0...@btinternet.com> wrote:
> On 03/08/16 17:01, Abel Abraham Camarillo Ojeda wrote:
>> On Tue, Mar 8, 2016 at 10:41 AM, Nigel Taylor
>> <njtaylor0...@btinternet.com> wrote:
>>
>>>
>>> Had a better look, depending on how the distribution is generated a
>>> Makefile.PL may or may not exist. If Makefile.PL doesn't exist Build.PL
>>> has to be used. These generate a Makefile.
>>>
>>>
>>> Dist::Zilla::Plugin::MakeMaker::Awesome is used to generate the
>>> Makefile.PL using the dist.ini
>>>
>>> Dist::Zilla::Plugin::ModuleBuildTiny is used to generate the Build.PL
>>> from dist.ini for Module::Build::Tiny.
>>>
>>> Dist::Zilla::Plugin::ModuleBuild is used to generate the Build.PL for
>>> Module::Build from dist.ini
>>>
>>> There are no Dist::Zilla..... / Dist::Milla.... in ports currently to
>>> try, used to send distribution to CPAN.
>>>
>>>
>>> modbuild shouldn't be used but maybe a modtiny style adding an extra
>>> style doesn't impact existing modbuild ports.
>>>
>>>
>>> modbuild will add the p5-Module-Build port to BUILD_DEPENDS for perl
>>> 5.22 (or you can edit every modbuild port for perl 5.22).
>>>
>>> modtiny should add p5-Module-Build-Tiny to BUILD_DEPENDS, as with
>>> modinst adding p5-Module-Install, then Module::Install depends on
>>> Module::Build, is a run depends for perl 5.22
>>
>> this seems like an strong enough argument to add a separate modtiny conf
>> style.
>>
>>
>>>
>>> Attached, diff revised p5-Starman port.
>>
>> looks ok to me
>>
>>> My perl.port.mk include some
>>> extras as building other ports at this time, can't remove mid dpb build.
>>>
>>> modinst - removes all bundled perl, needs some additional ports /
>>> dependency changes to build.
>>
>> can't comment on that right now
>>
>>> modbuild - adds p5-Module-Build to BDEP.
>>
>> looks good to me
>>
>>>
>>> revised p5-Geo-UK-Postcode-Regex below, and also p5-CGI-Compile
>>>
>>> $ cat Makefile
>>> # $OpenBSD: Makefile,v 1.2 2016/01/11 10:34:21 sthen Exp $
>>>
>>> COMMENT= regular expressions for handling British postcodes
>>>
>>> MODULES= cpan
>>> DISTNAME= Geo-UK-Postcode-Regex-0.015
>>> CATEGORIES= geo
>>>
>>> # Perl
>>> PERMIT_PACKAGE_CDROM= Yes
>>>
>>> MAINTAINER= Stuart Henderson <st...@openbsd.org>
>>>
>>> BUILD_DEPENDS= devel/p5-File-ShareDir-Install
>>> TEST_DEPENDS= devel/p5-Test-Exception \
>>> devel/p5-Clone
>>>
>>> CONFIGURE_STYLE= modtiny
>>>
>>> .include <bsd.port.mk>
>>> $ make show=BUILD_DEPENDS
>>> devel/p5-File-ShareDir-Install devel/p5-Module-Build-Tiny devel/ccache
>>>
>>> If modbuild had been used would of had p5-Module-Build included in BDEP,
>>> when only p5-Module-Build-Tiny is required.
>>>
>>>
>>> Also works switching from Makefile.PL to Build.PL - only tried the one
>>> (should have removed \ ok for checking the change over).
>>>
>>> $ cvs -R -q diff -uNp
>>> Index: Makefile
>>> ===================================================================
>>> RCS file: /home/cvs/ports/devel/p5-MooseX-Types/Makefile,v
>>> retrieving revision 1.12
>>> diff -u -p -r1.12 Makefile
>>> --- Makefile 12 Jun 2015 13:46:08 -0000 1.12
>>> +++ Makefile 8 Mar 2016 15:12:07 -0000
>>> @@ -17,9 +17,10 @@ RUN_DEPENDS = devel/p5-Carp-Clan \
>>> devel/p5-Sub-Name \
>>> devel/p5-namespace-autoclean
>>> BUILD_DEPENDS = ${RUN_DEPENDS} \
>>> - devel/p5-Module-Build-Tiny
>>>
>>> TEST_DEPENDS = devel/p5-Test-Fatal \
>>> devel/p5-Test-Requires
>>> +
>>> +CONFIGURE_STYLE = modtiny
>>>
>>> .include <bsd.port.mk>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>> about your perl.port.mk,
>>
>> isn't this duplicated:
>>
>> +. if !target(do-build)
>> +do-build:
>> + @${MODPERL_BUILD_TARGET}
>> +. endif
>> +. if !target(do-test)
>> +do-test:
>> + @${MODPERL_TEST_TARGET}
>> +. endif
>> +. if !target(do-install)
>> +do-install:
>> + @${MODPERL_INSTALL_TARGET}
>> +. endif
>> +.endif
>>
>>
>> [...]
>>
>> . if !target(do-build)
>> do-build:
>> @${MODPERL_BUILD_TARGET}
>> . endif
>> . if !target(do-test)
>> do-test:
>> @${MODPERL_TEST_TARGET}
>> . endif
>> . if !target(do-install)
>> do-install:
>> @${MODPERL_INSTALL_TARGET}
>> . endif
>> .endif
>>
>>
>> or I'm reading it wrong?
>>
> it's
>
> .if ...modbuild
> . if
>
> . endif
> .endif
>
> .if ...modtiny
> . if
>
> . endif
> .endif
>
> Yes it's duplicated a lot of what inside the .if .endif
> But found it easier than adding,
>
> .if ....modbuild ....modtiny
>
> .endif
>
> and leaves the original modbuild, even if the diff doesn't quite show
> that in a nice way,
>
>> thanks for interest/help!
>>
>>
>
Yes, I got fooled by the diff, sorry
