Dnia 2016-03-10, o godz. 00:54:47 Stuart Henderson <[email protected]> napisał(a):
> On 2016/03/10 01:37, Adam Wolk wrote: > > > > Additionally a comment indicating that MASTER_SITES is used to avoid > > auto tools hell would be nice. Reason being that common sense would > > suggest to use GH_* variables for a github hosted port. > > I tried to explain this in > ports/infrastructure/templates/Makefile.template, can you think of > any changes that would make it clearer (without making it too long)? > > -> > > # For github: traditional tarballs in /releases/download are normally > # preferred if available; use them with DISTNAME/MASTER_SITES lines as > # normal. For projects using auto-generated tarballs, set GH_ACCOUNT, > # GH_PROJECT, and *one* of GH_TAGNAME or GH_COMMIT. For GH_COMMIT, > also # set DISTNAME. For GH_TAGNAME, set DISTNAME if the default is > no good. > > I don't think a comment is necessary in ports themselves, I would > hope people don't go changing them without thinking as to why > it's done like that :-) > > There are several reasons to prefer "a tarball that someone has > specifically prepared and uploaded for the release" rather than > whatever archive github produces for a particular tag at the time > of downloading (which is much more likely to be a moving target). > Agreed, like mentioned on IRC I tested on an outdated ports checkout without that addition :) > > The port itself works and builds fine. I would be ok importing > > assuming the above changes. Any OK's? > > OK as-is. > DESCR reads a bit awkwardly but that could be tweaked later. > Thanks, imported into textproc/jo as-is. Regards, Adam
