On Fri, Mar 18, 2016 at 12:19:16AM +0100, Jeremie Courreges-Anglas wrote:
> Joerg Jung <[email protected]> writes:
>
> > please find attached a port for the tiny dstat utility, which is written
> > for and requires x11/dwm.
> >
> > $ cat pkg/DESCR
> > dstat is a lightweight utility to set the dwm status bar text. dstat
> > displays
> > the current network throughput, CPU usage, performance settings, battery
> > status, temperature, volume settings, as well as the current date and time
> > on
> > the dwm status bar.
> >
> >
> > Comments, OKs for import?
>
> cc -c -Os -ansi -pedantic -Wall -Wextra -Isrc -I/usr/include
> -I/usr/local/include -I/usr/X11R6/include -o dstat.o dstat.c
> This ^^^ is wrong, ports should respect DEBUG=-g / CFLAGS.
Right. I fixed that before import.
> dstat.c includes machine/apmvar.h, shouldn't this port be
> ONLY_FOR_ARCHS=${APM_ARCHS}?
Oh, very good catch! Added.
> Except for this, looks fine.
>
> mandoc catched this:
> $ mandoc -Tlint dstat.1
> mandoc: dstat.1:88:2: WARNING: unusual Xr punctuation: . before apm(4)
Thanks, also fixed in imported version.
