On Thu, 21 Apr 2016 01:54:38 +0200 "Dmitrij D. Czarkoff" <czark...@gmail.com> wrote:
> Adam Wolk said: > > I'm inlining a patch for sysutils/logstash/forwarder replacing the > > usage of INSTALL_PROGRAM with INSTALL_SCRIPT and a comment informing > > why this choice is made. Any OK's? > > OK czarkoff@. A cleaner approach would be to set > Thanks. Committed. > | INSTALL_STRIP= > > but that is a user setting which may be overriden in mk.conf. > I agree but if it's known to produce crashing binaries and is officially not supported by upstream then giving people a knob to turn off binary stripping is not what we should do? Regards, Adam
