attila <[email protected]> writes: > attila <[email protected]> writes: > >> attila <[email protected]> writes: >> >>> attila <[email protected]> writes: >>> >>>> Micah Muer <[email protected]> writes: >>>> >>>>> On Tue, 22 Mar 2016 12:58:32 -0600 >>>>> attila <[email protected]> wrote: >>>>> >>>>>> Stuart Henderson <[email protected]> writes: >>>>>> >>>>>> > On 2016/03/19 15:38, Michael McConville wrote: >>>>>> >> > +ALL_TARGET = deprecated >>>>>> >> > + >>>>>> >> > +# golf MAKE_FLAGS down to 80chars.. :-| >>>>>> >> > +_i = -include >>>>>> >> > +_incs = ${_i} src/GLibFacade.h ${_i} src/version.h >>>>>> >> > ${_i} src/parser.h >>>>>> >> > +MAKE_FLAGS = CFLAGS="${CFLAGS} ${_incs}" >>>>>> >> >>>>>> >> Why golf? Can't you just use backslashes as necessary? I would get rid >>>>>> >> of _i and _incs. >>>>>> >> >>>>>> > >>>>>> > I think this approach is dangerous, better to keep those bits which are >>>>>> > normally part of upstream's Makefile in their Makefile and change the >>>>>> > way that you pass in CFLAGS. (e.g. maybe pass in COPTFLAGS instead and >>>>>> > change their Makefile to do COPTFLAGS?=-O3 and "CFLAGS?=${COPTFLAGS} >>>>>> > ... >>>>>> > -include ...") >>>>>> > >>>>>> > But then again, we have cmake, why not just use that? It's upstream's >>>>>> > preferred build infrastructure, whereas for the make-based one they say >>>>>> > "I don't recommend this approach, but it should work in a pinch".. >>>>>> >>>>>> Agree, this was sleazy and poorly considered. I'm sorry. Anytime I >>>>>> find myself golfing I should stop. >>>>>> >>>>>> Attached is new attempt that uses cmake instead. Works for me on i386. >>>>>> >>>>>> N.B.: I set NO_TEST to Yes now because the tests are buried in a git >>>>>> submodule; furthermore, the repo on which the submodule is based has >>>>>> no tags and thus no releases, making it impossible for me to reach out >>>>>> for it as a distfile (unless I'm missing something). I'm going to try >>>>>> to convince the upstream to start tagging that repo, but if I fail >>>>>> then I'll self-host a tarball for tests on the next update. >>>>>> >>>>>> Thanks as always for the feedback. >>>>>> >>>>>> Pax, -A >>>>>> -- >>>>>> http://haqistan.net/~attila | [email protected] | 0x62A729CF >>>>> >>>>> Atilla's patch works well for me on amd64. I have used it heavily for >>>>> several days. However, upstream has a new release, so here's a new >>>>> patch 99% based on atilla's. >>>> >>>> Nice! Thanks for doing this. Works for me on i386. >>> >>> Ping? Diff attached that includes Micah Muer's updates. >>> >>> Pax, -A >> >> Reping? New patch attached that brings us up to 5.2.0-1, released 16 >> March. Nothing new, just updated distinfo and Makefile. Works for me >> under amd64, i386. >> >> Pax, -A > > Ping. > > Pax, -A
Ping. Pax, -A -- http://haqistan.net/~attila | [email protected] | 0x62A729CF
