On 2016/06/07 22:47, Frederic Cambus wrote:
> On Tue, Jun 07, 2016 at 07:36:00PM +0200, Daniel Jakots wrote:
> 
> > > Here is a new port, for snappy. Tested on amd64.
> > 
> > One minor nits: The last sentence of the second
> > paragraph about SHARED_LIBS in bsd.port.mk(5) is:
> > 
> > > For that reason it is advised to set libversion to 0.0 when first
> > > importing a port.
> 
> Indeed. Thanks for the reminder, I was aware of the rule but not sure
> what I had in mind..
> 
> > Other than that, looks good to me. If any more experienced porter wants
> > to import it, you have my ok :)
> 
> Nice! Attaching a new tarball with corrected SHARED_LIBS version.
> Thanks for testing.
> 

autoconf picks up gtest and gflags, please either add BUILD_DEPENDS
on these, or tell autoconf not to use them.

..
checking for 'gtest-config'... checking for gtest-config...
/usr/local/bin/gtest-config
/usr/local/bin/gtest-config
checking for Google Test... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for gflags... no
..

Reply via email to