On Mon, Jun 27, 2016 at 07:51:33PM +0000, Christian Weisgerber wrote:
> On 2016-06-27, Patrik Lundin <pat...@sigterm.se> wrote:
> 
> > CXX_DUMP_VERSION=`$CXX -dumpversion | cut -f1-2 -d.`
> > if test "$CXX_DUMP_VERSION" \< "4.5"; then
> >        WARNING_GCC_44_STRICT_ALIASING_CFLAG="-fno-strict-aliasing"
> > fi
> >
> > The error message is thrown because the builtin test does not support
> > the "<" operator (which /bin/test does).
> 
> That's not portable.  POSIX does not specify an operator < for test.
> 
> For a portable solution, use expr(1) instead.
> 

Thanks, that sounds like the most proper way forward. I have opened a PR
against upstream, lets see what they think:
https://github.com/isc-projects/kea/pull/25

I guess the side effect of fixing the check (adding
"-fno-strict-aliasing" to the build even if not strictly needed) is not
really detrimental to the build.

-- 
Patrik Lundin

Reply via email to