On 2016/08/18 12:12, Jeremie Courreges-Anglas wrote: > Stuart Henderson <[email protected]> writes: > > > As most readers know by now, ports requiring WX mappings must now > > be annotated when the binaries are created. Because there are many > > build systems in ports (sometimes even different ones within a > > single port) this is an utter pain to setup, so for the jdk ports > > I've used a wrapper installed to ${WRKDIR}/bin/ld that adds the > > relevant flag. > > > > This factors out the wrapper so it can be generated by ports > > infrastructure instead (by setting USE_WXNEEDED=Yes), and adds > > it to the sqlports database so we can spot them more easily. > > > > Any comments? > > This may not be enough to fix everything (eg lisp stuff that dumps > executables) but whatever.
Agreed, I don't think we are going to fix everything this way, but it makes the more common cases a lot easier. > I guess that you didn't want to introduce a more generic ld wrapper > script? I hadn't thought of that.. I certainly like the simple USE_WXNEEDED flag and feeding that into sqlports, if we needed to add some other flags we could switch to a more generic wrapper and have USE_WXNEEDED trigger adding to that. I can't think of a use case right now though. > > OK? > > Looks fine, ok > > (one nit below) good call, I'll switch to @.
