On 2016/08/19 12:01, David Coppa wrote: > On Fri, 19 Aug 2016, Stuart Henderson wrote: > > > On 2016/08/18 22:00, Caspar Schutijser wrote: > > > Hi, > > > > > > trojita violates W^X at runtime. USE_WXNEEDED=Yes does not work in this > > > case so I patched CMakeLists.txt. > > > > Unless adding USE_WXNEEDED actually breaks things, I thing we should add > > it anyway for documentation purposes. I'll test that and commit it with > > that change if it works. > > I think my diff below is nicer. > Tested on amd64.
Merging the two (I do really want to get USE_WXNEEDED set for ports which need the linker flag if at all possible..), how about this? (Side-note from testing - this is another of those Qt apps which jumps the mouse pointer around the screen when you move it out of a modal dialogue box using cwm as window manager... does anyone have a clue what's going on there?) Index: Makefile =================================================================== RCS file: /cvs/ports/mail/trojita/Makefile,v retrieving revision 1.14 diff -u -p -r1.14 Makefile --- Makefile 9 Aug 2016 01:34:05 -0000 1.14 +++ Makefile 19 Aug 2016 10:07:45 -0000 @@ -1,15 +1,20 @@ # $OpenBSD: Makefile,v 1.14 2016/08/09 01:34:05 jturner Exp $ +# ld wrapper doesn't actually fix build, but setting USE_WXNEEDED for +# documentation purposes. see CONFIGURE_ARGS. +USE_WXNEEDED = Yes # QtWebKit + COMMENT = fast Qt IMAP e-mail client DISTNAME = trojita-0.6 REVISION = 0 -CATEGORIES = mail x11 - SHARED_LIBS = trojita_plugins 1.0 # 1.0 +CATEGORIES = mail x11 + HOMEPAGE = http://trojita.flaska.net/ +MAINTAINER = Caspar Schutijser <[email protected]> MASTER_SITES = ${MASTER_SITE_SOURCEFORGE:=trojita/} EXTRACT_SUFX = .tar.bz2 @@ -31,7 +36,8 @@ CONFIGURE_ENV += QTDIR="${MODQT_LIBDIR}" CONFIGURE_ARGS += -DWITH_RAGEL=OFF \ -DWITH_QT5=OFF \ -DWITH_QTKEYCHAIN_PLUGIN=OFF \ - -DGIT_EXECUTABLE="" + -DGIT_EXECUTABLE="" \ + -DCMAKE_EXE_LINKER_FLAGS="-Wl,-z,wxneeded" TEST_IS_INTERACTIVE = X11
