Hi Edgar,
I don't think we want to import libraries when nothing depends on / can
use them. What use cases do you have in mind?
Anyway, here is some feedback:
> # $OpenBSD: Makefile.template,v 1.73 2016/01/11 09:17:22 sthen Exp $
>
> COMMENT = Libxlsxwriter is a C library for creating Excel XLSX
> files.
"Libxlsxwriter is a" is not useful, the period should be dropped.
> GH_ACCOUNT= jmcnamara
> GH_PROJECT= libxlsxwriter
> DISTNAME= master
Nope. master is a moving target, not a tag. Also, a distfile named
"master.tar.gz" is not very usable.
>
> PKGNAME= ${GH_PROJECT}-0.4.2
It would probably be better to set GH_TAGNAME to RELEASE_0.4.2 and then
adjust DISTNAME. That would also remove the need to set WRKDIST below.
>
> CATEGORIES = devel
devel is too crowded. textproc or math would be better I think.
> HOMEPAGE = http://libxlsxwriter.github.io/index.html
> MAINTAINER = Edgar Pettijohn <[email protected]>
Trailing whitespace.
>
> # BSD
> PERMIT_PACKAGE_CDROM = Yes
>
> USE_GMAKE = Yes
> WRKDIST = ${WRKDIR}/${GH_PROJECT}-${DISTNAME}
>
> do-install:
> ${INSTALL_DATA} ${WRKSRC}/lib/libxlsxwriter.{a,so} ${PREFIX}/lib
> ${INSTALL_DATA} ${WRKSRC}/include/xlsxwriter.h ${PREFIX}/include
This can't be right, you're missing lots of include files that should go
to include/xlsxwriter/.
> ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/libxlsxwriter
> ${INSTALL_DATA} ${WRKSRC}/examples/*.c
> ${PREFIX}/share/examples/libxlsxwriter/
> ${INSTALL_DATA} ${WRKSRC}/docs/images/*.png
> ${PREFIX}/share/examples/libxlsxwriter/
> .include <bsd.port.mk>
Also:
- you should pass V=1 (MAKE_FLAGS) to the build system so that commands
are shown
- the build system uses -O3, this should be patched out
- LDFLAGS is not respected for the final link stage of the shared lib,
this prevents one from building a package with debugging symbols
included in the shared lib. (make clean repackage DEBUG=-g)
I'm not completely opposed to including this port, but we should have
a good reason. People using this library for in-house development only
are probably better served by relying directly on upstream releases.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
