On Mon, Oct 03, 2016 at 11:28:02AM +0200, Dmitrij D. Czarkoff wrote:
> Edd Barrett <[email protected]> wrote:
> | editing the DESCR file and then running it through fmt -w 80.
I stand corrected.
> I've added some comments.
Thanks
> I have accidentally overriden CFLAGS, and default "-O2 -pipe" were not
> fed to port. Thus hardcoded "-O3" was used, and this overoptimization
> caused the crash. New revision of the port removes hardcoded CFLAGS
> from port and appends to CFLAGS instead of overriding them.
Yep that helps.
But I can still crash the game quite easily:
* Play the opening move.
* In the moves pane, select a move.
* Choose "analyse->analyse move" from the menu
* Click "new" button on the toolbar
* Click OK on new game dialog
* OK, discard current match
*CRASH*
---8<---
...
(edd) new match 7
Program received signal SIGSEGV, Segmentation fault.
0x0000129bd3bd9f98 in custom_cell_renderer_movelist_render (cell=Variable
"cell" is not available.
) at /usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gtkmovelistctrl.c:372
372 if (phd->piHighlight && cellprogress->rank - 1 == *phd->piHighlight)
#1 0x0000129e21de3639 in gtk_tree_view_column_cell_process_action () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#2 0x0000129e21de44a9 in _gtk_tree_view_column_cell_render () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#3 0x0000129e21de0b96 in gtk_tree_view_expose () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#4 0x0000129e21cd651f in _gtk_marshal_BOOLEAN__BOXED () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#5 0x0000129e23b686b3 in g_closure_invoke () from
/usr/local/lib/libgobject-2.0.so.4200.3
#6 0x0000129e23b7eeee in signal_emit_unlocked_R () from
/usr/local/lib/libgobject-2.0.so.4200.3
#7 0x0000129e23b80dff in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#8 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#9 0x0000129e21df425f in gtk_widget_event_internal () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#10 0x0000129e21cd0310 in gtk_main_do_event () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#11 0x0000129e95b79ef3 in _gdk_window_process_updates_recurse () from
/usr/local/lib/libgdk-x11-2.0.so.2400.0
#12 0x0000129e95b79f33 in _gdk_window_process_updates_recurse () from
/usr/local/lib/libgdk-x11-2.0.so.2400.0
#13 0x0000129e95b79f33 in _gdk_window_process_updates_recurse () from
/usr/local/lib/libgdk-x11-2.0.so.2400.0
#14 0x0000129e95b75e35 in gdk_window_process_updates_internal () from
/usr/local/lib/libgdk-x11-2.0.so.2400.0
#15 0x0000129e95b77dae in gdk_window_process_updates () from
/usr/local/lib/libgdk-x11-2.0.so.2400.0
#16 0x0000129e23b686b3 in g_closure_invoke () from
/usr/local/lib/libgobject-2.0.so.4200.3
#17 0x0000129e23b7ed2f in signal_emit_unlocked_R () from
/usr/local/lib/libgobject-2.0.so.4200.3
#18 0x0000129e23b812a9 in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#19 0x0000129e21e555a5 in gtk_signal_emit_by_name () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#20 0x0000129e21e2fa02 in adjust_adjustments () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#21 0x0000129e21e2fb19 in clist_refresh () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#22 0x0000129bd3b584d8 in ClearMoveRecord () at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/play.c:689
#23 0x0000129bd3b5db75 in NewGame () at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/play.c:776
#24 0x0000129bd3b5dfa7 in StartNewGame () at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/play.c:2691
#25 0x0000129bd3b5e92b in CommandNewMatch (sz=0x129e63f268ab "") at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/play.c:2828
#26 0x0000129bd3b31777 in HandleCommand (sz=0x129e63f268aa "7",
ac=0x129bd3ebac48) at /usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gnubg.c:1231
#27 0x0000129bd3b31887 in HandleCommand (sz=0x129e63f268a4 "match",
ac=0x129bd3eb9e60) at /usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gnubg.c:1235
#28 0x0000129bd3b326dc in ProcessInput (sz=0x129e307dcf20 "new match 7") at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gnubg.c:3619
#29 0x0000129bd3b32842 in UserCommand (szCommand=Variable "szCommand" is not
available.
) at /usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gnubg.c:3674
#30 0x0000129bd3ba820b in NewOK (pw=0x129e3b399190, pnw=Variable "pnw" is not
available.
) at /usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gtkgame.c:4488
#31 0x0000129e23b69a21 in g_cclosure_marshal_VOID () from
/usr/local/lib/libgobject-2.0.so.4200.3
#32 0x0000129e23b6842d in _g_closure_invoke_va () from
/usr/local/lib/libgobject-2.0.so.4200.3
#33 0x0000129e23b80876 in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#34 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#35 0x0000129e23b6842d in _g_closure_invoke_va () from
/usr/local/lib/libgobject-2.0.so.4200.3
#36 0x0000129e23b80876 in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#37 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#38 0x0000129e21c24ddb in gtk_real_button_released () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#39 0x0000129e23b684d7 in _g_closure_invoke_va () from
/usr/local/lib/libgobject-2.0.so.4200.3
#40 0x0000129e23b80876 in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#41 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#42 0x0000129e21c23139 in gtk_button_button_release () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#43 0x0000129e21cd651f in _gtk_marshal_BOOLEAN__BOXED () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#44 0x0000129e23b68750 in g_closure_invoke () from
/usr/local/lib/libgobject-2.0.so.4200.3
#45 0x0000129e23b7eeee in signal_emit_unlocked_R () from
/usr/local/lib/libgobject-2.0.so.4200.3
#46 0x0000129e23b80dff in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#47 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#48 0x0000129e21df425f in gtk_widget_event_internal () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#49 0x0000129e21ccedf9 in gtk_propagate_event () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#50 0x0000129e21cd013f in gtk_main_do_event () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#51 0x0000129e95b93210 in gdk_event_dispatch () from
/usr/local/lib/libgdk-x11-2.0.so.2400.0
#52 0x0000129e8f0552ff in g_main_context_dispatch () from
/usr/local/lib/libglib-2.0.so.4200.3
#53 0x0000129e8f05735b in g_main_context_iterate () from
/usr/local/lib/libglib-2.0.so.4200.3
#54 0x0000129e8f0582d5 in g_main_loop_run () from
/usr/local/lib/libglib-2.0.so.4200.3
#55 0x0000129e21cd0511 in gtk_main () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#56 0x0000129bd3bdabda in GTKRunDialog (dialog=0x129e3b399190) at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gtkwindows.c:456
#57 0x0000129bd3ba8a15 in GTKNew () at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gtkgame.c:4515
#58 0x0000129e23b6842d in _g_closure_invoke_va () from
/usr/local/lib/libgobject-2.0.so.4200.3
#59 0x0000129e23b80876 in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#60 0x0000129e23b8198d in g_signal_emit_by_name () from
/usr/local/lib/libgobject-2.0.so.4200.3
#61 0x0000129e23b6842d in _g_closure_invoke_va () from
/usr/local/lib/libgobject-2.0.so.4200.3
#62 0x0000129e23b80876 in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#63 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#64 0x0000129e21c24ddb in gtk_real_button_released () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#65 0x0000129e23b6842d in _g_closure_invoke_va () from
/usr/local/lib/libgobject-2.0.so.4200.3
#66 0x0000129e23b80876 in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#67 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#68 0x0000129e21c23139 in gtk_button_button_release () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#69 0x0000129e21cd651f in _gtk_marshal_BOOLEAN__BOXED () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#70 0x0000129e23b686b3 in g_closure_invoke () from
/usr/local/lib/libgobject-2.0.so.4200.3
#71 0x0000129e23b7eeee in signal_emit_unlocked_R () from
/usr/local/lib/libgobject-2.0.so.4200.3
#72 0x0000129e23b80dff in g_signal_emit_valist () from
/usr/local/lib/libgobject-2.0.so.4200.3
#73 0x0000129e23b81a71 in g_signal_emit () from
/usr/local/lib/libgobject-2.0.so.4200.3
#74 0x0000129e21df425f in gtk_widget_event_internal () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#75 0x0000129e21ccedf9 in gtk_propagate_event () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#76 0x0000129e21cd013f in gtk_main_do_event () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#77 0x0000129e95b93210 in gdk_event_dispatch () from
/usr/local/lib/libgdk-x11-2.0.so.2400.0
#78 0x0000129e8f0552ff in g_main_context_dispatch () from
/usr/local/lib/libglib-2.0.so.4200.3
#79 0x0000129e8f05735b in g_main_context_iterate () from
/usr/local/lib/libglib-2.0.so.4200.3
#80 0x0000129e8f0582d5 in g_main_loop_run () from
/usr/local/lib/libglib-2.0.so.4200.3
#81 0x0000129e21cd0511 in gtk_main () from
/usr/local/lib/libgtk-x11-2.0.so.2400.0
#82 0x0000129bd3baf0f7 in RunGTK (pwSplash=0x0, commands=0x0,
python_script=0x0, match=0x0)
at /usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gtkgame.c:4048
#83 0x0000129bd3b336b3 in main (argc=1, argv=0x7f7ffffd11d8) at
/usr/ports/pobj/gnubg-1.05.002/gnubg-1.05.002/gnubg.c:4652
(gdb) p *phd->piHighlight
Cannot access memory at address 0x129e92277c08
(gdb) p phd->piHighlight
$4 = (unsigned int *) 0x129e92277c08
--->8---
If we can fix this, I am OK to put the port in.
--
Best Regards
Edd Barrett
http://www.theunixzoo.co.uk
