On Wed, Sep 28, 2016 at 12:18:58AM -0600, Anthony J. Bentley wrote:
> > libretro-pcsx_rearmed provides a Sony PlayStation emulation core to the
> > RetroArch emulator frontend, based on PCSX ReARMed.
> > It is yet another PCSX fork based on the PCSX-Reloaded project, which itself
> > contains code from PCSX, PCSX-df and PCSX-Revolution.
> > Can be tested with the retroarch package.
> Anyone willing to ok this port?
I have been playing a few Bomberman games over the last few weeks and
the emulator works nicely.
Some nitpicking, though: I would change underscore to dash in DISTNAME
and DESCR. The various README files name the emulator as "PCSX-ReArmed",
and it's a bit akward to have underscores in ports/packages names.
Also, it would be nice to remove the failing calls to Git in Makefile,
possibly doing something like this:
--- Makefile.orig Sun Oct 16 10:57:23 2016
+++ Makefile Sun Oct 16 10:58:01 2016
@@ -240,9 +240,7 @@ libpcsxcore/gte_nf.o: libpcsxcore/gte.c
$(CC) -c -o $@ $^ $(CFLAGS) -DFLAGLESS
- @(git describe || echo) | sed -e 's/.*/#define REV "\0"/' > $@_
- @diff -q $@_ $@ > /dev/null 2>&1 || cp $@_ $@
- @rm $@_
+ @echo '#define REV "0"' > $@
$(CC_AS) $(CFLAGS) -c $^ -o $@