On 2016/11/03 07:10, Jeremy Evans wrote:
> The downside of this approach is to build nginx, you need to install
> all dependencies for all subpackages first.  

That's the standard way we do things anyway, and most of these deps
aren't *all* that huge.

I agree with this approach.

> It that becomes too
> much of a pain (especially for weaker arches), we can add
> PSEUDO_FLAVORS and bsd.port.arch.mk.

Might be useful later, but it's lower priority.

> The nginx modules are installed into /var/www/modules, and you
> need to use "load_module" at the top level fairly early on
> in the nginx.conf file to load them. I've updated the nginx.conf
> sample file to show an example.

> +                     --with-http_image_filter_module=dynamic \
> +                     --with-http_geoip_module=dynamic \
>                       --with-http_gzip_static_module \
> +                     --with-http_perl_module=dynamic \
>                       --with-http_realip_module \
>                       --with-http_slice_module \
>                       --with-http_ssl_module \
>                       --with-http_stub_status_module \
>                       --with-http_v2_module \
> -                     --with-mail \
> -                     --with-mail_ssl_module \

You're getting rid of mail_ssl_module rather than changing to dynamic,
is that intentional?

> +                     --with-http_xslt_module=dynamic \
> +                     --with-mail=dynamic \
>                       --with-ipv6 \
> -                     --with-stream

> -Available FLAVORs:
> -
> -     lua - This Nginx module embeds the Lua 5.1 interpreter or LuaJIT 2.0
> -into the nginx core and integrates the powerful Lua threads (aka Lua
> -coroutines) into the nginx event model by means of nginx subrequests.
> -
> -     mailproxy - enables the mail proxy features of nginx (specifically
> -the mail_pop3_module, the mail_imap_module, and the mail_smtp_module).
> -
> -     naxsi - This Nginx module embeds Naxsi into nginx core. Naxsi is
> -a high performance, low rules maintenance, Web Application Firewall module.
> -
> -     passenger - Phusion Passenger(R) a.k.a. mod_rails or mod_rack makes
> -deployment of Ruby web applications, such as those built on the revolutionary
> -Ruby on Rails web framework, a breeze. It follows the usual Ruby on Rails
> -conventions, such as "Don't-Repeat-Yourself".

The module DESCR-* could do with a little description I think.
You could use the text from old DESCR for the four it describes.

> Index: pkg/DESCR-main
> ===================================================================
> RCS file: pkg/DESCR-main
> diff -N pkg/DESCR-main
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ pkg/DESCR-main    1 Nov 2016 22:18:08 -0000
> @@ -0,0 +1,13 @@
> +This is the stable branch of nginx, as distributed by nginx.org.
> +
> +nginx provides FastCGI and reverse HTTP proxying, with or without caching,
> +including simple load balancing and fault tolerance.
> +
> +It has a modular architecture.  Filters include gzipping, byte ranges,
> +chunked responses, and SSI.  Multiple SSI inclusions within a single page
> +can be processed in parallel if they are handled by FastCGI or proxied
> +servers.  SSL and TLS SNI are supported.
> +
> +The mail proxy features user redirection to IMAP/POP3/SMTP backends
> +using an external HTTP authentication server, including SSL/STARTTLS
> +support and a range of authentication methods.

Description of mail proxy should probably go to DESCR-mailproxy rather
than DESCR-main.

> Index: pkg/PLIST-geoip
> ===================================================================
> RCS file: pkg/PLIST-geoip
> diff -N pkg/PLIST-geoip
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ pkg/PLIST-geoip   1 Nov 2016 00:02:07 -0000
> @@ -0,0 +1,3 @@
> +@comment $OpenBSD: PLIST,v 1.16 2014/10/23 12:13:12 sthen Exp $
> +@cwd /var/www/modules
> +ngx_http_geoip_module.so

@cwd in PLISTs is a pain, sometimes there is no alternative, but I think
you can just use PREFIX-geoip (etc) for most of these can't you? It's not
possible to avoid for the ones which also install files under /usr/local
(like -perl) but doing it that way should be easier for the usual cases.

Reply via email to