On Mon, Nov 28, 2016 at 05:26:42PM +0000, Nigel Taylor wrote: > On 11/28/16 15:38, Jeremie Courreges-Anglas wrote: > > Giovanni Bechis <giova...@paclan.it> writes: > > > >> pkg/DESCR: > >> Digest::SHA is a complete implementation of the NIST Secure Hash > >> Standard. <SNIP> > No you don't do this, fix what in base or wait for perl 5.26 to go into > base, your only adding what's going to have to be removed if put in > ports, unless > > ===> Checking files for p5-Module-CoreList-5.20161120
I do like how you pick a module that's in core, but also in ports as your example. (This one is pretty useful to be able to update outside of base perl though). <SNIP> > $ perl -Ilib ./corelist -a Digest::SHA | tail > v5.24.0 5.95 > v5.25.0 5.95 > v5.25.1 5.95 > v5.25.2 5.95 > v5.25.3 5.95 > v5.25.4 5.96 > v5.25.5 5.96 > v5.25.6 5.96 > v5.25.7 5.96 > > As can be seen 5.96 is in perl v5.25.4 onwards, which means it goes into > base so far it's not being removed from perl core. Having two version of > the same thing is not a good idea, as can end up using the wrong version. > > $ corelist Digest::SHA > > Data for 2015-09-12 > Digest::SHA was first released with perl v5.9.3 > > $ perl -e 'use Digest::SHA; print $Digest::SHA::VERSION."\n";' > 5.88_01 > > Also as in previous base releases these should also be patched in base, > if this need fixing. I agree that there's no real use in doing this, since I hope to get 5.24.1 imported shortly after it's released, which will include 5.95, plus the patch to remove '.' from @INC. AFAIK there is still "discussion" about how best to fix this "remove '.' from @INC" in the most backwards compatible way for 5.24.1 and 5.22.3. Handily for 5.26 there will be a flag to build perl without it in @INC at all, which I did backport to 5.24, tho that will not go in with the update, so we can see what fallout comes from that specifically. > The 5.88_01 suggests that the version in base might have been modified > in some way, or patched to fix problems in the past, which your now losing. It was, to remove the '.' from @INC, which is the change between 5.95 and 5.96. https://metacpan.org/changes/distribution/Digest-SHA
