On Wed, Nov 30, 2016 at 09:28:34PM +0100, Jeremie Courreges-Anglas wrote: > Sol??ne Rapenne <sol...@perso.pw> writes: > > > Hello, > > Hi, > > > I would like feedback about my port, it's a tool which generate > > makefile. > > > It's a shame that there isn't any documentation in the tarball... that's > not something you can fix of course, but adding a link to > https://github.com/premake/premake-core/wiki in DESCR could be helpful. > > BTW the content of DESCR is dubious, IMO. > https://github.com/premake/premake-core/wiki/What-Is-Premake has > a more neutral and informative description: > > "Premake is a command line utility which reads a scripted definition of > a software project and, most commonly, uses it to generate project files > for toolsets like Visual Studio, Xcode, or GNU Make." > > > .include <bsd.port.mk> > > Note that the build is silent which is bad. Adding verbose=1 to > MAKE_FLAGS would have helped to spot an -Os cc flag that shouldn't be > there. The link step shouldn't use -s since it makes DEBUG=-g useless. > > This seems to embed lua-5.1, using lua from ports could be nice - if > possible of course. >
I did a port of devel/premake4 some time ago https://marc.info/?l=openbsd-ports&m=147272474916111&w=2 this included a change to use our ports lua instead of the bundled one. When I researched the premake stuff before they have a big jump in premake5 and by the nature of the software it's possible that some ports will stick to premake4 and some will move to premake5 hence I believe the major version should be in the port name. When I ported this initially I had games/tome4 in mind but was put off by the amount of bundled libraries that game shipped. Regards, Adam
