Jeremie Courreges-Anglas <j...@wxcvbn.org> writes: > Andrew Fresh <and...@afresh1.com> writes: > >> On Mon, Dec 26, 2016 at 11:51:32AM -0600, attila wrote: >>> >>> attila <att...@stalphonsos.com> writes: >>> >>> > attila <att...@stalphonsos.com> writes: >>> > >>> >> Hi ports@, >>> >> >>> >> Attached is a port for the Data::SExpression Perl module. It is a >>> >> dependency of the Perl interface I recently contributed to mail/mu >>> >> upstream, and which will be coming down the pike in some new mu >>> >> release fairly soon. >>> >> >>> >> $ cat pkg/DESCR >>> >> Data::SExpression is a Perl module that parses LISP-like >>> >> S-expressions into Perl data structures. >>> >> >>> >> Passes make test on i386. >> >> Also on amd64, if it is in the "cpan" directory. >> >> >>> >> Comments, feedback most welcome. >> >> There is no "cpan" category, need to pick one. Perhaps devel, or >> textproc? > > Tough. I'd choose devel/ because the output is perl data structures, > and because considering s-expressions as text seems far-stretched to me. > But then, most ports dealing with XML are under textproc/... your call. > >> Don't start off the COMMENT with a capital letter unless it is >> semantically important (like the COMMENT is the expansion of an acronym >> or somesuch). >> >> You should add yourself as maintainer if you are interested in that. >> >> Should add a test dependency on devel/p5-Test-Memory-Cycle to avoid >> skipping tests. > > Test-Deep should probably go in TEST_DEPENDS instead of BUILD_DEPENDS, > it's not needed to build the package. > >> Some of the newlines in the Makefile can go away. >> >> Other than that, it looks OK to me. > > Same here. With the issues above addressed, ok jca@
Thanks a lot for the feedback. Attached is a revised port that I believe addresses all concerns raised. Passes tests on amd64. Pax, -A -- https://haqistan.net/~attila | attila@{stalphonsos.com,haqistan.net} pgp: 0x62A729CF | C2CE 2487 03AC 4C2F 101D 09C1 4068 D5D5 62A7 29CF
p5-Data-SExpression-bis.tgz
Description: updated port of Data::SExpression
