On Sat, Feb 25, 2017 at 02:44:50PM +0000, Edd Barrett wrote:
> On Sat, Feb 11, 2017 at 01:26:50PM +0000, Edd Barrett wrote:
> > OK?
> 
> Any love for this, so we can push on with neovim?

Lots of compiler warnings for such a small library...

Most of them are flukes, I think, but this one should be fixed since
without it, the 8bit CSI won't be recognized:

    84    char c;
    85  
    86    /* await CSI - 8bit or 2byte 7bit form */
    87    bool in_esc = false;
    88    while((c = getchar())) {
    89      if(c == 0x9b)
    90        break;

To make this actually work, c should be an int.  The attached file
is patches/patch-bin_vterm-ctrl_c.
$OpenBSD$

Fix signed versus unsigned comparison.

--- bin/vterm-ctrl.c.orig       Sun Dec 18 21:03:40 2016
+++ bin/vterm-ctrl.c    Sat Feb 25 16:29:14 2017
@@ -81,7 +81,7 @@ static char *read_csi()
 {
   /* TODO: This really should be a more robust CSI parser
    */
-  char c;
+  int c;
 
   /* await CSI - 8bit or 2byte 7bit form */
   bool in_esc = false;

Reply via email to