On Mon, Mar 06, 2017 at 04:19:00PM +0100, Remi Locherer wrote:
> On 2017-03-06 13:11, Marcus MERIGHI wrote:
> > [email protected] (Remi Locherer), 2017.03.06 (Mon) 08:34 (CET):
> > > On Sun, Mar 05, 2017 at 10:42:33PM +0000, Stuart Henderson wrote:
> > > > On 2017/03/05 23:21, Remi Locherer wrote:
> > > > > attached a port of vdirsyncer plus it's dependencies.
> > > >
> > > > I've just had a quick read through; in a few of the ports you have 
> > > > hardcoded
> > > > ,python3 in deps, this should be ${MODPY_FLAVOR}. It's a noop for 
> > > > vdirsyncer
> > > > itself though we are generally doing this anyway and it saves trouble if
> > > > we change things in ports later, but for some of the other ports it's
> > > > wrong as-is i.e. py-requests-toolbelt depends on www/py-requests,python3
> > > > even for the py27 one. Similarly should use 
> > > > sphinx-build${MODPY_BIN_SUFFIX}
> > > > rather than hardcoded sphinx-build-3.
> > > >
> > > > One other nit, please use "Yes" instead of "YES" for 
> > > > PERMIT_PACKAGE_CDROM.
> > > >
> > > > Other than that, looks good to me.
> > > 
> > > Thank you for reviewing my ports!
> > > 
> > > Attached updated tarballs.
> > 
> > Happy tester here: works.
> > 
> > Thanks for bringing that software to my doorstep!
> > 
> > For py-click-log I had to change the distinfo to:
> > 
> > SHA256 (click-log-0.1.8.tar.gz) =
> > 57271008c12e2dc16d413373bedd7fd3ff17c57434e168650dc27dfb9c743392
> > SIZE (click-log-0.1.8.tar.gz) = 9277
> > 
> > vdirsyncer Makefile had to be adjusted:
> > 
> > -BUILD_DEPENDS =         textproc/py-sphinx,python3
> > +BUILD_DEPENDS =         textproc/py3-sphinx,python3
> 
> argh ... I missed this one. It shold be:
> 
> BUILD_DEPENDS =         textproc/py-sphinx,${MODPY_FLAVOR}
> 
> I'll send an updated tarball tonight. Thanks for testing!
> 

Here it is: vdirsyncer with this fix and deps attached to this mail.

Remi

Attachment: py-atomicwrites.tar.gz
Description: application/tar-gz

Attachment: py-click-log.tar.gz
Description: application/tar-gz

Attachment: py-click-threading.tar.gz
Description: application/tar-gz

Attachment: py-requests-toolbelt.tar.gz
Description: application/tar-gz

Attachment: vdirsyncer.tar.gz
Description: application/tar-gz

Reply via email to