On Sun, Mar 26, 2017 at 12:53:57PM +0000, Robert Peichaer wrote:
> This updates textproc/p5-ack to version 2.18.
> All tests pass.
> -V = 2.15_02
> +V = 2.18
In general I try to avoid _ development CPAN releases in ports.
Good that you fix this.
> PKGNAME= p5-${DISTNAME:S/_/./}
This line is exists due to the old _ version. You can remove it.
The cpan module should create the correct package name automatically.
> BUILD_DEPENDS= ${RUN_DEPENDS}
A bunch of Perl ports have this line although it is not needed. In
general a missing build dependency may print a warning during build
that is not important. At some point there was consensus to avoid
this BUILD_DEPENDS to have less dependencies on the port build
machines.
Can you try whether it works without it and remove the line?
> RUN_DEPENDS= devel/p5-File-Next
Now the port needs File::Next => '1.16'. We have this version in
our ports tree. Could you change the dependency to
devel/p5-File-Next>=1.16 ? This makes port updates easier as the
reviewer does not have to check /usr/ports/INDEX manually.
OK bluhm@
