On Wed, Mar 29, 2017 at 03:05:51AM +0200, Jeremie Courreges-Anglas wrote: > Gleydson Soares <[email protected]> writes: > > >> If upstream has an autoconf-like mechanism, better wrap this in > >> #ifdef HAVE_PLEDGE statements. If not, better keep local patches, at > >> least we can easily keep track of them. > > > > sure, meanwhile we should also send it upstream and protecting these > > calls by adding #ifdef is ok to make consistency with other suckless > > tools. ii and sic pledge() patches have been merged: > > http://git.suckless.org/ii/commit/?id=584290f2642eeacbe1b24e7174e49139d6787252 > > http://git.suckless.org/sic/commit/?id=9bb34de449c8f22d869a6f3794107ed25d37c7c1 > > eww... > > Making it consistent with existing bad practices is not a good thing. > People should check for features like "does this OS provide pledge?" > instead of dumb OS checks. This really feels like the 80's.
You need rebuild the package just to change the terminal colors. I guess that asking for a configure script is a lot for them :P > > The approach used in the commits above is just this, bad practices, and > I don't feel like we should encourage it by sending similar patches. > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE > -- Juan Francisco Cantero Hurtado http://juanfra.info
