Marcus Glocker <[email protected]> writes: > KiwiIRC is a web-based IRC client built using Node.js. It runs as > standalone which means it doesn't require an underlying HTTP server. > > Comments, OKs?
You can't use npm install like this, the build process should not fetch from the network. I think you should use a do-build target instead of do-configure/NO_BUILD. Installing to /usr/local/kiwiirc seems dubious at best, shouldn't stuff be installed in /usr/local/lib/kiwiirc and/or /usr/local/share/kiwiirc? -$(command -v nodejs || command -v node) $basedir/server/helpers/launcher.js "$@" +$(command -v nodejs || command -v node) $basedir/server/helpers/launcher.js "$@" -p /var/log/kiwiirc/kiwiirc.pid /var/log seems like a weird choice for a pid file, you can install /var/run/kiwiirc in the rc script. Is this pid file actually needed? pexp="node: kiwiirc*" <- did you mean pexp="node: kiwiirc.*" (a regular expression)? Standard reminder: the tree is locked right now. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
