On Wed, Apr 12, 2017 at 11:45:48AM +0200, Theo Buehler wrote:
> On Wed, Apr 12, 2017 at 03:18:48AM -0600, Anthony J. Bentley wrote:
> > Anton Lindqvist writes:
> > > On Mon, Mar 06, 2017 at 08:54:36PM +0100, Anton Lindqvist wrote:
> > > > The pick(1) utility allows users to select from a set of choices using
> > > > an interface with fuzzy search functionality. The choices are read from
> > > > stdin, and the selected choice written to stdout.
> > > > 
> > > > I'm a contributor and maintainer of pick. This port has been
> > > > submitted[1] earlier but not committed. I've talked to Mike about this
> > > > re-submission and on taking over as the maintainer. Notable changes
> > > > since the last submission: pledge:d and a test-suite is in place.
> > > > 
> > > > https://github.com/calleerlandsson/pick
> > > > 
> > > > [1] http://marc.info/?l=openbsd-ports&m=142547614218768&w=2
> > > 
> > > Ping
> > 
> > This looks good to me. Anyone willing to ok so I can import?
> > 
> 
> Putting the initial pledge before setlocale is a bit iffy, so I wonder
> whether we should add a patch changing that.
> 
> Apart from that, the port looks good to me.

Attached is an updated port of pick-1.6.0 which fixes the issue earlier
discussed. Complete changelog below:

- Fix memory leak

- Postpone initial pledge call

- Don't match strings inside escape sequences

- Calculate the width of each displayed character

- Define _GNU_SOURCE in order to make wcwidth(3) available on Linux

- Test suite improvements

- Exit with 0 on success and 1 on failure instead of using the exit
  codes defined in sysexits.h

https://github.com/calleerlandsson/pick/releases/tag/v1.6.0

Attachment: pick.tar.gz
Description: application/tar-gz

Reply via email to