Marc Espie <[email protected]> writes: > On Fri, Jun 16, 2017 at 08:03:46PM +0100, Stuart Henderson wrote: >> On 2017/06/15 09:10, Sebastian Reitenbach wrote: >> > > >> > > Make test doesn't work, I guess problem with a $SHELL, however, running >> > > 'gmake test' in the >> > > build directory runs 38 tests, 0 failures, 5 errors. >> > > The 5 errors are all related to the missing refCount from TRObject. >> > > >> > > Maybe the tests could be patched, or even just not built at all? >> > >> > I decided to patch the tests instead of omitting them, so patch below now >> > builds tests without warning and runs the remaining 28 tests without >> > failures. >> >> It doesn't matter if some tests fail. It's more transparent to just >> let them fail, than it is to patch to disable them. >> >> > > Someone who uses it, might want to test it? >> > > I also have a LDAP server setup here, but no openvpn server around to >> > > test, >> > > so could take a while to set it up properly. >> > > >> > > Other comments patches cleanup etc. welcome as well, as this was just >> > > quickly hacked together so far ;) >> >> Since it is currently broken and packages are not being built, >> I think it would be OK to just commit, then it will be easier for >> anyone using it to give feedback. > > I concur. Sounds like the most reasonable path.
+1 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
