On 2017/07/03 15:50, Jeremie Courreges-Anglas wrote:
> Stuart Henderson <[email protected]> writes:
> 
> > This makes sense to me, any differing opinions?
> 
> Makes sense.
> 
> libmtp builds fine with clang from base on amd64.  If the same can be
> said about misp64el, then maybe
> 
>   COMPILER=base gcc
>   MODGCC4_ARCHS= misp64el
> 
> would be nicer in the long run.

This would just be

COMPILER=       gcc
MODGCC4_ARCHS=  mips64el
COMPILER_LANGS= c

We don't have clang on mips64el anyway, but if we were to ever get it,
that would avoid having to change it later. So I think that would be the
right thing to do.

> > I would add a comment explaining what it's for, just something like
> > << # avoid "libmtp.so.7.0: undefined reference to `.L2085'" >>
> 
> ack

So in total:

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/libmtp/Makefile,v
retrieving revision 1.35
diff -u -p -r1.35 Makefile
--- Makefile    30 May 2017 20:48:04 -0000      1.35
+++ Makefile    3 Jul 2017 14:26:28 -0000
@@ -16,6 +16,11 @@ WANTLIB += c gcrypt gpg-error iconv intl
 
 MASTER_SITES=          ${MASTER_SITE_SOURCEFORGE:=libmtp/}
 
+# avoid "libmtp.so.7.0: undefined reference to `.L2085'"
+COMPILER=              gcc
+COMPILER_LANGS=                c
+MODGCC4_ARCHS=         mips64el
+
 LIB_DEPENDS=           devel/libusb1 \
                        security/libgcrypt
 

Reply via email to