On Fri, Jul 07, 2017 at 03:46:10PM +0000, Bryan C. Everly wrote: > On Fri, Jul 7, 2017 at 11:08 AM Antoine Jacoutot < > > > > > Looks good. > > I forgot to mention but could you add these lines at the top of the PLIST: > > > > @unexec-delete rm -f %D/share/icons/material-design-dark/icon-theme.cache > > @unexec-delete rm -f %D/share/icons/material-design-light/icon-theme.cache > > > I put those at the bottom based on some other ports. Do I need to put them > at the top?
They are not present in the diff you sent. If you have them locally at the bottom, put them at the top please. > > That's because the port installs a complete icons theme set and the cache > > file > > will be left around when uninstalling the package. > > Also there's a second diff in your mail (src-qt5/desktop-utils/ > > desktop-utils.pro), > > what is it for? > > > I added that additional file (it is a new patch to not build a lumina tool > that won't compile because our version of qt5 is too old) because I > couldn't get cvs diff -N to work as advertised. It needs to be dropped into > the patches directory as a new file. put it in patches then cvs add patches/patch-qt5-foo > Please let me know if you'd like for me to regenerate the diff and thanks > again for all of your help to date. Yes please, this way I can commit it verbatim. Thanks -- Antoine
