On Mon, Aug 14, 2017 at 02:30:27PM -0700, Ayaka Koshibe wrote: > Apologies, wrong attachment - correct one attached. > > On Mon, Aug 14, 2017 at 2:25 PM, Ayaka Koshibe <[email protected]> wrote: > > I've addressed the comments - updates attached. > > So now the description, which I read before installing a package, is referring to the package's content for more details. I meant something along the lines of "heavily patched - here be dragons" so users know this before installing it.
> >> `make test' says "Ran 0 tests in 0.000s"; that's not intentional, is it? > > > > The regression tests are intentionally empty, since they involve > > destructive actions like creating/destroying interfaces. I see. Here are some more comments; sorry for splitting this into two mails, I've been looking into it more closely just now; MODPY_EGG_VERSION must be set as described in port-modules(5), make sure to have PLIST updated accordingly. devel/pep8 is not used and can thus be removed as BUILD_DEPENDS. PREFIX should be used instead of LOCALBASE for setting *DIR as you've already done in the pre-install target. You can set SEPARATE_BUILD, but then README.md must not be installed from WRKBUILD anymore. Example files go under /usr/local/share/examples/mininet, not the python site-packages directory. Why do you patch files such as the INSTALL-* ones if they're aren't used or installed anyway? Why are the platform specific files under freebsd/ and linux/ which are known not to work for us obviously installed? Minor style nits: Indenting the broken help2man line (by four spaces) makes it easier to read and distinguish from another command itself. I'd also insert a newline before the bsd.port.mk include. Thanks for your work on this port, I'm looking forward to it!
