For comments see below.
Rafael Sadowski
On Mon Sep 25, 2017 at 04:39:39PM +0000, Jérôme KASPER wrote:
> Hi ports,
>
> Diff corrected for glm for later 6.3 :
>
> index 76ca41ffd7e..4dff35fcec0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2,11 +2,9 @@
>
> COMMENT= C++ mathematics header-only library for OpenGL software
>
> -GH_TAGNAME= 0.9.8.4
> GH_PROJECT= glm
> GH_ACCOUNT= g-truc
> -DISTNAME= ${GH_PROJECT}-${GH_TAGNAME}
> -REVISION= 0
> +GH_TAGNAME= 0.9.8.5
Do all consumers build with is update?
>
> CATEGORIES= graphics math
>
> @@ -17,14 +15,14 @@ PERMIT_PACKAGE_CDROM= Yes
>
> MODULES= devel/cmake
>
> -COMPILER = gcc
> +COMPILER = base-clang
man bsd.port.mk and search for COMPILER. Does it not compile with
ports-gcc?
> WANTLIB += ${COMPILER_LIBCXX}
>
> # it's kind-of a NO_BUILD port, but doing so means you can't
> # run the tests.
> CONFIGURE_ARGS+=-DGLM_TEST_ENABLE=BOOLEAN=ON
All tests green?
>
> -CXXFLAGS+= -Wno-long-long
> +CXXFLAGS+= -std=c++11 -Wno-long-long
Is "-no-long-long" still necessary and is "c++11" flag essential?
>
> PKG_ARCH= *
>
> diff --git a/distinfo b/distinfo
> index 8ccf7b2ce23..d7667f3170d 100644
> --- a/distinfo
> +++ b/distinfo
> @@ -1,2 +1,2 @@
> -SHA256 (glm-0.9.8.4.tar.gz) = oiDmD4cRJlWVvjIh5TDWMtWCNkHs1Go6VLwXSTO/8Uw=
> -SIZE (glm-0.9.8.4.tar.gz) = 3769208
> +SHA256 (glm-0.9.8.5.tar.gz) = gM+ZWPBuVQT430XqFP3odBEnAQKTC+McChbA2kMPySA=
> +SIZE (glm-0.9.8.5.tar.gz) = 3756809
> diff --git a/patches/patch-CMakeLists_txt b/patches/patch-CMakeLists_txt
> deleted file mode 100644
> index b50b48c382f..00000000000
> --- a/patches/patch-CMakeLists_txt
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -$OpenBSD: patch-CMakeLists_txt,v 1.3 2017/06/15 18:02:17 rsadowski Exp $
> -Index: CMakeLists.txt
> ---- CMakeLists.txt.orig
> -+++ CMakeLists.txt
> -@@ -77,6 +77,7 @@ if(GLM_TEST_ENABLE_LANG_EXTENSIONS)
> - if(GLM_TEST_ENABLE_FAST_MATH)
> - if(CMAKE_COMPILER_IS_GNUCXX)
> - add_definitions(-ffast-math)
> -+ add_definitions(-mfpmath=387)
> - endif()
> -
> - if(MSVC)
I guess if you build it with ports-gcc, you need this patch.
> diff --git a/pkg/PLIST b/pkg/PLIST
> index a81c73495b7..599e3d632ff 100644
> --- a/pkg/PLIST
> +++ b/pkg/PLIST
> @@ -1,4 +1,4 @@
> -@comment $OpenBSD: PLIST,v 1.3 2017/06/15 18:02:17 rsadowski Exp $
> +@comment $OpenBSD$
Wrong, you did not work with the last version from CVS.
> include/glm/
> include/glm/CMakeLists.txt
> include/glm/common.hpp
> @@ -215,12 +215,6 @@ include/glm/gtx/rotate_vector.inl
> include/glm/gtx/scalar_multiplication.hpp
> include/glm/gtx/scalar_relational.hpp
> include/glm/gtx/scalar_relational.inl
> -include/glm/gtx/simd_mat4.hpp
> -include/glm/gtx/simd_mat4.inl
> -include/glm/gtx/simd_quat.hpp
> -include/glm/gtx/simd_quat.inl
> -include/glm/gtx/simd_vec4.hpp
> -include/glm/gtx/simd_vec4.inl
> include/glm/gtx/spline.hpp
> include/glm/gtx/spline.inl
> include/glm/gtx/std_based_type.hpp
