On Tue 07/11/2017 11:50, Manolis Tzanidakis wrote:
> Hello,
> here is an updated port for the latest version (0.7.3) of restic.
> 
> Besides the version bump, I've added the installation of manpages and a couple
> of tiny modifications to Björn's original port. Tested on amd64.
> 
> Very nice back-up tool; would be really grateful if anyone cares to commit it.
> 
> On Fri (13/01/17), Björn Ketelaars wrote:

Manolis,

Please note that:
1.) make test fails on some tests, which require root. I think it makes sense
  to add something like below to do-test:

       @[ `id -u` == 0 ] || printf \
       "\n*** NOTE: restic fails on some tests, which require root ***\n\n"

2.) another regression test issue is
  https://github.com/restic/restic/issues/1307. I have send a fix - which
  works for me: https://github.com/restic/restic/pull/1414. My patch however
  has not (yet) been accepted upstream. For the fix to work on 0.7.3. I'm
  using the diff below this mail.

I've more-or-less settled for borgbackup as my backup solution, and I'm only
following restic from a distance. I would appreciate it if you could remove me
as MAINTAINER.

-- 
Björn Ketelaars
GPG key: 0x4F0E5F21


diff -ruN restic/patches/patch-cmd_restic_integration_helpers_test_go 
restic.new/patches/patch-cmd_restic_integration_helpers_test_go
--- restic/patches/patch-cmd_restic_integration_helpers_test_go Thu Jan  1 
01:00:00 1970
+++ restic.new/patches/patch-cmd_restic_integration_helpers_test_go     Sun Nov 
 5 07:14:05 2017
@@ -0,0 +1,24 @@
+$OpenBSD$
+
+Index: cmd/restic/integration_helpers_test.go
+--- cmd/restic/integration_helpers_test.go.orig
++++ cmd/restic/integration_helpers_test.go
+@@ -71,7 +71,17 @@ func sameModTime(fi1, fi2 os.FileInfo) bool {
+               }
+       }
+ 
+-      return fi1.ModTime().Equal(fi2.ModTime())
++      same := fi1.ModTime().Equal(fi2.ModTime())
++      if !same && (runtime.GOOS == "darwin" || runtime.GOOS == "openbsd") {
++              // Allow up to 1μs difference, because macOS <10.13 cannot 
restore
++              // with nanosecond precision and the current version of Go 
(1.9.2)
++              // does not yet support the new syscall. (#1087)
++              mt1 := fi1.ModTime()
++              mt2 := fi2.ModTime()
++              usecDiff := (mt1.Nanosecond()-mt2.Nanosecond())/1000 + 
(mt1.Second()-mt2.Second())*1000000
++              same = usecDiff <= 1 && usecDiff >= -1
++      }
++      return same
+ }
+ 
+ // directoriesEqualContents checks if both directories contain exactly the 
same

Reply via email to