On 2017/11/15 07:59, Martijn van Duren wrote: > On 11/14/17 23:20, Stuart Henderson wrote: > > On 2017/11/14 16:53, Daniel Jakots wrote: > >> On Tue, 14 Nov 2017 19:54:55 +0100, Martijn van Duren > >> <openbsd+po...@list.imperialat.at> wrote: > >> > >>> Hello ports@, > >>> > >>> As requested by sthen@ I will cut up my big patch into smaller pieces. > >>> This is the first part of that undertaking. > >>> > >>> I will send in 1 at the time since a lot intermingles with > >>> Makefile.inc and I don't want stacking patches to cause trouble. > >>> > >>> If someone objects to a certain patch I'll just drop it till it's the > >>> right time to discuss it, so to not keep the things that can move > >>> along. > >>> > >> > >> Subject: PHP: clean Makefile.inc of 5.x specifics: then would you mind > >> running "/usr/ports/lang/php$ sed -i 's/php5/php/' Makefile.inc"? :p > >> It's a bit weird to do a pkg_info and see: > >> php-curl-7.0.23 curl URL library extensions for php5 > >> > >> Cheers, > >> Daniel > >> > > > > I agree this makes sense. It will need more than just s//, all subpackages > > will need bumping too. > > > That was the next thing on my agenda. This was also in my original patch, > but one thing at a time. > I'll probably leave these 3 as is, since they disappeared in php7, so it's > a bit more informative why they're not there for php7. > > @sthen@: Do we want that bump with the coming diff for the s/php5/php/ > diff and all the following, or shall we accumulate these minor diffs > that don't change anything substantial and bump them all in one go? (maybe > when we jump to 5.6.32 and 7.0.25?)
It seems sensible to change those with the updates, it doesn't add too much noise to the diff.
