On Thu, Nov 30, 2017 at 03:25:31PM +0000, Job Snijders wrote: > On Thu, Nov 30, 2017 at 01:53:35PM +0100, Klemens Nanni wrote: > > devel/py-radix has no FLAVORS, > > You may need to update your ports tree, I updated py-radix yesterday. Ah, my bad.
> > portcheck(1) tells you that. > > Sorry, I'm not familiar with 'portcheck', where can I find more > information? You can find both the script and it's manual under /usr/ports/infrastructure/, the porting guide also refers to it. > > I'd also suggest turning the -python3 FLAVOR into a simple > > MODPY_VERSION=${MODPY_DEFAULT_VERSION_3} so we can avoid future Python > > 2 ports. > > Yeah I was struggling a bit what to do in this regard. With python3 the > aggregate6 code performs slightly better compared to python2. Ideally > the 'aggregate6' cli tool points to the python3 interpreter, and the > python2 version is available as 'aggregate6-2' or something. I'm sill in favor of just dropping the -2 flavor completely simply to encourage Python 3 usage. Otherwise I'm afraid that Python 2 versions keep lingering around for way too long. > However I purposefully wrote aggregate6 in such a way that it can work > in both python2 and python3 environments to enable broader > applicability. Fair point with regards to portability but not when it comes to new ports. These are just my to cents, I'm happy to hear from others. Attached is a diff on top of your tarball to ship it as Python 3 only, only lightly tested. --- Makefile.orig Thu Nov 30 13:09:25 2017 +++ Makefile Thu Nov 30 17:18:38 2017 @@ -10,33 +10,24 @@ HOMEPAGE= https://github.com/job/aggregate6/ -MAINTAINER = Job Snijders <j...@openbsd.org> +MAINTAINER= Job Snijders <j...@openbsd.org> # BSD PERMIT_PACKAGE_CDROM= Yes +MODULES= lang/python + MODPY_PI= Yes MODPY_SETUPTOOLS= Yes +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3} -FLAVORS= python3 -FLAVOR?= - -MODULES= lang/python - -RUN_DEPENDS= devel/py-radix${MODPY_FLAVOR} - -.if !${FLAVOR:Mpython3} -RUN_DEPENDS+= devel/py-future \ +RUN_DEPENDS= devel/py-future \ + devel/py-radix${MODPY_FLAVOR} \ net/py-ipaddress -.endif TEST_DEPENDS= ${RUN_DEPENDS} \ devel/py-coverage${MODPY_FLAVOR} \ devel/py-mock${MODPY_FLAVOR} \ devel/py-nose${MODPY_FLAVOR} - -post-install: - mv ${PREFIX}/bin/aggregate6{,${MODPY_BIN_SUFFIX}} - mv ${PREFIX}/man/man7/aggregate6{,${MODPY_BIN_SUFFIX}}.7 .include <bsd.port.mk>