Hi.
The textproc/filepp port has no maintainer, and the current filepp package
installs a filepp script that won't run due to the following error:
Global symbol "$DESTDIR" requires explicit package name (did you forget
to declare "my $DESTDIR"?) at /usr/local/bin/filepp line 43.
Execution of /usr/local/bin/filepp aborted due to compilation errors.
Line 43 of /usr/local/bin/filepp reads:
push(@INC, "${DESTDIR}/usr/local/share/filepp/modules");
I've used filepp successfully on OpenBSD before, but not for a couple of
years or so. Reviewing the port history, I see that revision 1.6 (October
2015) of textproc/filepp/Makefile removed the following code:
post-configure:
@perl -pi -e 's,\$${DESTDIR},,g;' ${WRKSRC}/filepp
Reverting that change makes filepp work again, but introduces the
following warning into the "configure" phase of the build:
Unescaped left brace in regex is deprecated, passed through in regex;
marked by <-- HERE in m/\${ <-- HERE DESTDIR}/ at -e line 1.
Switching from perl to sed is one way to avoid the warning. Would a ports
committer please review the following diff, and commit it if it's OK?
Thanks.
Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/filepp/Makefile,v
retrieving revision 1.8
diff -u -p -r1.8 Makefile
--- Makefile 15 Nov 2017 21:28:05 -0000 1.8
+++ Makefile 22 Dec 2017 23:44:37 -0000
@@ -3,7 +3,7 @@
COMMENT = cpp-like generic file pre-processor
DISTNAME = filepp-1.8.0
-REVISION = 2
+REVISION = 3
CATEGORIES = textproc devel
MASTER_SITES = http://www-users.york.ac.uk/~dm26/filepp/
@@ -16,5 +16,8 @@ CONFIGURE_STYLE = gnu dest
NO_BUILD = Yes
PKG_ARCH = *
TEST_TARGET = fulltest
+
+post-configure:
+ sed -i 's,$${DESTDIR},,g' ${WRKSRC}/filepp
.include <bsd.port.mk>
--
"On two occasions I have been asked [by members of Parliament!], `Pray, Mr.
Babbage, if you put into the machine wrong figures, will the right answers
come out?' I am not able rightly to apprehend the kind of confusion of
ideas that could provoke such a question." -- Charles Babbage
